Issue 960123006: Merge 190872 "Traverse subframes during PrintContext::outputLink..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 960123006: Merge 190872 "Traverse subframes during PrintContext::outputLink..." (Closed)

Created:
5 years, 9 months ago by Xianzhu

Modified:
5 years, 9 months ago

Reviewers:
Xianzhu

CC:
blink-reviews

Base URL:
svn://svn.chromium.org/blink/branches/chromium/2311/

Project:
blink

Visibility:
Public.

Merge 190872 "Traverse subframes during PrintContext::outputLink..." > Traverse subframes during PrintContext::outputLinkAndLinkedDestinations() > > When divorcing PDF link annotation from paintFocusRing() > (https://src.chromium.org/viewvc/blink?view=rev&revision=181070) we > missed the links in subframes > > Also traverse subframes for links (but not anchors and links to > anchors because our PrintContext supports only one namespace for > anchor names). > > BUG=459894 > TEST=PrintContextFrameTest.WithSubframe > R=eae@chromium.org > TBR= web/ change of a call site of parameter change. > > Review URL: https://codereview.chromium.org/944533003 TBR=wangxianzhu@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191010

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+92 lines, -14 lines)			Patch
M	Source/core/page/PrintContext.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/page/PrintContext.cpp	View	2 chunks	+15 lines, -7 lines	0 comments	Download
M	Source/core/page/PrintContextTest.cpp	View	6 chunks	+75 lines, -5 lines	0 comments	Download
M	Source/web/WebLocalFrameImpl.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 2 (0 generated)

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as r191010.