Issue 944533003: Traverse subframes during PrintContext::outputLinkAndLinkedDestinations()

Issue 944533003: Traverse subframes during PrintContext::outputLinkAndLinkedDestinations() (Closed)

Created:
5 years, 10 months ago by Xianzhu

Modified:
5 years, 10 months ago

Reviewers:
esprehn, eae

CC:
blink-reviews

Base URL:
svn://svn.chromium.org/blink/trunk

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

Traverse subframes during PrintContext::outputLinkAndLinkedDestinations() When divorcing PDF link annotation from paintFocusRing() (https://src.chromium.org/viewvc/blink?view=rev&revision=181070) we missed the links in subframes Also traverse subframes for links (but not anchors and links to anchors because our PrintContext supports only one namespace for anchor names). BUG=459894 TEST=PrintContextFrameTest.WithSubframe R=eae@chromium.org TBR= web/ change of a call site of parameter change. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190872

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+92 lines, -14 lines)			Patch
M	Source/core/page/PrintContext.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/page/PrintContext.cpp	View	1 chunk	+15 lines, -7 lines	0 comments	Download
M	Source/core/page/PrintContextTest.cpp	View	6 chunks	+75 lines, -5 lines	0 comments	Download
M	Source/web/WebLocalFrameImpl.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 7 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/944533003/1

5 years, 10 months ago (2015-02-25 22:24:06 UTC) #6

commit-bot: I haz the power

5 years, 10 months ago (2015-02-26 00:59:01 UTC) #7

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190872