Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(555)

Issue 960103003: Revert of Fix memory leak caused by field type in descriptor array. (Closed)

Created:
5 years, 10 months ago by marja
Modified:
5 years, 10 months ago
Reviewers:
ulan, Toon Verwaest
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Fix memory leak caused by field type in descriptor array. (patchset #3 id:40001 of https://codereview.chromium.org/955063002/) Reason for revert: Breaks test/mjsunit/debug-clearbreakpointgroup.js on arm64.debug. Original issue's description: > Fix memory leak caused by field type in descriptor array. > > When a field type is a map, it is wrapped in a weak cell upon storing to the descriptor array. > > Map::GetFieldType(i) does the unwrapping. > > BUG=v8:3877 > LOG=N > TEST=cctest/test-heap/Regress3877 > > Committed: https://crrev.com/77d3ae0e119893ac8d34ea6ca090cddd5bbf987e > Cr-Commit-Position: refs/heads/master@{#26879} TBR=verwaest@chromium.org,ulan@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:3877 Committed: https://crrev.com/b57be748b175695be2507cedf3423b59b9d6cd20 Cr-Commit-Position: refs/heads/master@{#26883}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -99 lines) Patch
M src/objects.h View 1 chunk +1 line, -4 lines 0 comments Download
M src/objects.cc View 8 chunks +20 lines, -43 lines 0 comments Download
M src/objects-inl.h View 1 chunk +1 line, -6 lines 0 comments Download
M src/property.h View 1 chunk +3 lines, -7 lines 0 comments Download
M test/cctest/test-heap.cc View 1 chunk +0 lines, -34 lines 0 comments Download
M test/cctest/test-migrations.cc View 1 chunk +3 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
marja
Created Revert of Fix memory leak caused by field type in descriptor array.
5 years, 10 months ago (2015-02-26 14:45:25 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/960103003/1
5 years, 10 months ago (2015-02-26 14:45:54 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-26 14:46:06 UTC) #3
commit-bot: I haz the power
5 years, 10 months ago (2015-02-26 14:46:18 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b57be748b175695be2507cedf3423b59b9d6cd20
Cr-Commit-Position: refs/heads/master@{#26883}

Powered by Google App Engine
This is Rietveld 408576698