Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Unified Diff: test/cctest/test-heap.cc

Issue 960103003: Revert of Fix memory leak caused by field type in descriptor array. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/property.h ('k') | test/cctest/test-migrations.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/test-heap.cc
diff --git a/test/cctest/test-heap.cc b/test/cctest/test-heap.cc
index 2d8d7b9d787a2a28023017b20e08b89d7cce6ee8..b5e091fc42d95e4ee8cc5ef4d8dc6c293cceb1da 100644
--- a/test/cctest/test-heap.cc
+++ b/test/cctest/test-heap.cc
@@ -5083,40 +5083,6 @@
}
-TEST(Regress3877) {
- CcTest::InitializeVM();
- Isolate* isolate = CcTest::i_isolate();
- Heap* heap = isolate->heap();
- Factory* factory = isolate->factory();
- HandleScope scope(isolate);
- CompileRun("function cls() { this.x = 10; }");
- Handle<WeakCell> weak_prototype;
- {
- HandleScope inner_scope(isolate);
- v8::Local<v8::Value> result = CompileRun("cls.prototype");
- Handle<JSObject> proto =
- v8::Utils::OpenHandle(*v8::Handle<v8::Object>::Cast(result));
- weak_prototype = inner_scope.CloseAndEscape(factory->NewWeakCell(proto));
- }
- CHECK(!weak_prototype->cleared());
- CompileRun(
- "var a = { };"
- "a.x = new cls();"
- "cls.prototype = null;");
- for (int i = 0; i < 4; i++) {
- heap->CollectAllGarbage(Heap::kNoGCFlags);
- }
- // The map of a.x keeps prototype alive
- CHECK(!weak_prototype->cleared());
- // Change the map of a.x and make the previous map garbage collectable.
- CompileRun("a.x.__proto__ = {};");
- for (int i = 0; i < 4; i++) {
- heap->CollectAllGarbage(Heap::kNoGCFlags);
- }
- CHECK(weak_prototype->cleared());
-}
-
-
#ifdef DEBUG
TEST(PathTracer) {
CcTest::InitializeVM();
« no previous file with comments | « src/property.h ('k') | test/cctest/test-migrations.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698