Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Unified Diff: remoting/remoting_webapp.gypi

Issue 959963002: [Chromoting] Enable jscompile for webapp unittests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rename sinon.$testStub -> sinon.TestStub Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | remoting/remoting_webapp_files.gypi » ('j') | remoting/webapp/base/js/auth_init.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/remoting_webapp.gypi
diff --git a/remoting/remoting_webapp.gypi b/remoting/remoting_webapp.gypi
index 7d72c677e2ba83e1425d9ba9ac449661eb253d9e..e7b00fdbe7e2c5dc16924741c7caf3d966e54c7d 100644
--- a/remoting/remoting_webapp.gypi
+++ b/remoting/remoting_webapp.gypi
@@ -24,6 +24,7 @@
'variables': {
'success_stamp': '<(PRODUCT_DIR)/<(_target_name)_jscompile.stamp',
'success_stamp_bt': '<(PRODUCT_DIR)/<(_target_name)_bt_jscompile.stamp',
+ 'success_stamp_ut': '<(PRODUCT_DIR)/<(_target_name)_ut_jscompile.stamp',
},
'actions': [
{
@@ -49,7 +50,7 @@
'inputs': [
'<@(remoting_webapp_crd_js_files)',
'<@(remoting_webapp_browsertest_all_js_files)',
- '<@(remoting_webapp_js_proto_files)',
+ '<@(remoting_webapp_browsertest_js_proto_files)',
],
'outputs': [
'<(success_stamp_bt)',
@@ -61,7 +62,27 @@
'--success-stamp', '<(success_stamp_bt)',
'<@(remoting_webapp_crd_js_files)',
'<@(remoting_webapp_browsertest_all_js_files)',
- '<@(remoting_webapp_js_proto_files)',
+ '<@(remoting_webapp_browsertest_js_proto_files)',
+ ],
+ },
+ {
+ 'action_name': 'Verify remoting webapp unittests',
+ 'inputs': [
+ '<@(remoting_webapp_crd_js_files)',
+ '<@(remoting_webapp_unittest_all_js_files)',
+ '<@(remoting_webapp_unittest_js_proto_files)',
+ ],
+ 'outputs': [
+ '<(success_stamp_ut)',
+ ],
+ 'action': [
+ 'python', '../third_party/closure_compiler/checker.py',
+ '--strict',
+ '--no-single-file',
+ '--success-stamp', '<(success_stamp_ut)',
+ '<@(remoting_webapp_crd_js_files)',
+ '<@(remoting_webapp_unittest_all_js_files)',
+ '<@(remoting_webapp_unittest_js_proto_files)',
],
},
], # actions
« no previous file with comments | « no previous file | remoting/remoting_webapp_files.gypi » ('j') | remoting/webapp/base/js/auth_init.js » ('J')

Powered by Google App Engine
This is Rietveld 408576698