Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(481)

Unified Diff: remoting/webapp/base/js/auth_init.js

Issue 959963002: [Chromoting] Enable jscompile for webapp unittests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rename sinon.$testStub -> sinon.TestStub Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/webapp/base/js/auth_init.js
diff --git a/remoting/webapp/base/js/auth_init.js b/remoting/webapp/base/js/auth_init.js
index c67e454143a62a48befa3f45afd8c475fbe29f5d..009edd149f4a5e7cb07bceb10cfccd856c85c70d 100644
--- a/remoting/webapp/base/js/auth_init.js
+++ b/remoting/webapp/base/js/auth_init.js
@@ -42,12 +42,14 @@ remoting.initIdentity = function(onUserInfoAvailable) {
}
}
- remoting.identity.getUserInfo().then(function(userInfo) {
- onUserInfoAvailable(userInfo.email, userInfo.name);
- }).catch(function(error) {
- onGetIdentityInfoError(
- /** @type {remoting.Error} */ (error));
- });
+ remoting.identity.getUserInfo().then(
+ /** @param {{email:string, name:string}} userInfo */
kelvinp 2015/02/28 03:03:52 change in this file shouldn't be necessary.
garykac 2015/02/28 03:28:23 I agree. Sadly, jscompile says it is. :-(
+ function(userInfo) {
+ onUserInfoAvailable(userInfo.email, userInfo.name);
+ }).catch(function(error) {
+ onGetIdentityInfoError(
+ /** @type {remoting.Error} */ (error));
+ });
};
/**
@@ -64,4 +66,4 @@ remoting.handleAuthFailureAndRelaunch = function() {
window.location.reload();
}
});
-};
+};

Powered by Google App Engine
This is Rietveld 408576698