Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(704)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 959913003: cleanup patch generation to preseve comments and remove @patch (Closed)

Created:
5 years, 10 months ago by Jennifer Messerly
Modified:
5 years, 10 months ago
Reviewers:
vsm
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

cleanup patch generation to preseve comments and remove @patch the only human authored changes here are tool/patch_sdk.dart R=vsm@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/f3aea59b7b1f1a05ee09e4b50c69e5c4582ea60c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1035 lines, -386 lines) Patch
M test/dart_codegen/expect/_internal/list.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/dart_codegen/expect/_internal/print.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/dart_codegen/expect/_internal/symbol.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/dart_codegen/expect/async/deferred_load.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/dart_codegen/expect/async/schedule_microtask.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/dart_codegen/expect/async/timer.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M test/dart_codegen/expect/collection/hash_map.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M test/dart_codegen/expect/collection/hash_set.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M test/dart_codegen/expect/collection/linked_hash_map.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M test/dart_codegen/expect/collection/linked_hash_set.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M test/dart_codegen/expect/convert/json.dart View 8 chunks +13 lines, -13 lines 0 comments Download
M test/dart_codegen/expect/convert/utf.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/dart_codegen/expect/core/bool.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/dart_codegen/expect/core/date_time.dart View 1 chunk +30 lines, -30 lines 0 comments Download
M test/dart_codegen/expect/core/double.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M test/dart_codegen/expect/core/errors.dart View 3 chunks +7 lines, -7 lines 0 comments Download
M test/dart_codegen/expect/core/expando.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M test/dart_codegen/expect/core/function.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/dart_codegen/expect/core/identical.dart View 1 chunk +5 lines, -6 lines 0 comments Download
M test/dart_codegen/expect/core/int.dart View 2 chunks +3 lines, -4 lines 0 comments Download
M test/dart_codegen/expect/core/list.dart View 3 chunks +8 lines, -8 lines 0 comments Download
M test/dart_codegen/expect/core/object.dart View 1 chunk +7 lines, -7 lines 0 comments Download
M test/dart_codegen/expect/core/regexp.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M test/dart_codegen/expect/core/stopwatch.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M test/dart_codegen/expect/core/string.dart View 4 chunks +9 lines, -9 lines 0 comments Download
M test/dart_codegen/expect/core/string_buffer.dart View 2 chunks +8 lines, -8 lines 0 comments Download
M test/dart_codegen/expect/core/uri.dart View 28 chunks +41 lines, -41 lines 0 comments Download
M test/dart_codegen/expect/math/math View 3 chunks +26 lines, -27 lines 0 comments Download
M test/dart_codegen/expect/math/random.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/dart_codegen/expect/typed_data/typed_data View 18 chunks +41 lines, -51 lines 0 comments Download
M test/generated_sdk/lib/async/deferred_load.dart View 1 chunk +6 lines, -1 line 0 comments Download
M test/generated_sdk/lib/async/schedule_microtask.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/generated_sdk/lib/async/timer.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/generated_sdk/lib/collection/hash_map.dart View 2 chunks +40 lines, -2 lines 0 comments Download
M test/generated_sdk/lib/collection/hash_set.dart View 2 chunks +28 lines, -2 lines 0 comments Download
M test/generated_sdk/lib/collection/linked_hash_map.dart View 2 chunks +36 lines, -2 lines 0 comments Download
M test/generated_sdk/lib/collection/linked_hash_set.dart View 2 chunks +29 lines, -2 lines 0 comments Download
M test/generated_sdk/lib/convert/json.dart View 2 chunks +6 lines, -18 lines 0 comments Download
M test/generated_sdk/lib/convert/utf.dart View 1 chunk +0 lines, -1 line 0 comments Download
M test/generated_sdk/lib/core/bool.dart View 1 chunk +18 lines, -1 line 0 comments Download
M test/generated_sdk/lib/core/date_time.dart View 3 chunks +70 lines, -13 lines 0 comments Download
M test/generated_sdk/lib/core/double.dart View 1 chunk +34 lines, -1 line 0 comments Download
M test/generated_sdk/lib/core/errors.dart View 2 chunks +1 line, -4 lines 0 comments Download
M test/generated_sdk/lib/core/expando.dart View 2 chunks +20 lines, -3 lines 0 comments Download
M test/generated_sdk/lib/core/function.dart View 1 chunk +22 lines, -1 line 0 comments Download
M test/generated_sdk/lib/core/identical.dart View 1 chunk +12 lines, -2 lines 0 comments Download
M test/generated_sdk/lib/core/int.dart View 2 chunks +37 lines, -2 lines 0 comments Download
M test/generated_sdk/lib/core/list.dart View 3 chunks +38 lines, -3 lines 0 comments Download
M test/generated_sdk/lib/core/object.dart View 2 chunks +28 lines, -4 lines 0 comments Download
M test/generated_sdk/lib/core/regexp.dart View 1 chunk +6 lines, -1 line 0 comments Download
M test/generated_sdk/lib/core/stopwatch.dart View 1 chunk +4 lines, -2 lines 0 comments Download
M test/generated_sdk/lib/core/string.dart View 2 chunks +48 lines, -3 lines 0 comments Download
M test/generated_sdk/lib/core/string_buffer.dart View 3 chunks +11 lines, -6 lines 0 comments Download
M test/generated_sdk/lib/core/uri.dart View 1 chunk +9 lines, -2 lines 0 comments Download
M test/generated_sdk/lib/internal/list.dart View 1 chunk +24 lines, -1 line 0 comments Download
M test/generated_sdk/lib/internal/print.dart View 1 chunk +0 lines, -1 line 0 comments Download
M test/generated_sdk/lib/internal/symbol.dart View 1 chunk +0 lines, -1 line 0 comments Download
M test/generated_sdk/lib/math/math.dart View 1 chunk +103 lines, -11 lines 0 comments Download
M test/generated_sdk/lib/math/random.dart View 1 chunk +5 lines, -1 line 0 comments Download
M test/generated_sdk/lib/typed_data/typed_data.dart View 18 chunks +160 lines, -41 lines 0 comments Download
M tool/patch_sdk.dart View 1 chunk +5 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Jennifer Messerly
5 years, 10 months ago (2015-02-25 21:09:49 UTC) #2
vsm
lgtm
5 years, 10 months ago (2015-02-25 21:22:16 UTC) #3
Jennifer Messerly
5 years, 10 months ago (2015-02-25 21:23:28 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
f3aea59b7b1f1a05ee09e4b50c69e5c4582ea60c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698