Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Side by Side Diff: test/generated_sdk/lib/internal/list.dart

Issue 959913003: cleanup patch generation to preseve comments and remove @patch (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « test/generated_sdk/lib/core/uri.dart ('k') | test/generated_sdk/lib/internal/print.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 part of dart._internal; 5 part of dart._internal;
6 6
7 /** 7 /**
8 * Mixin that throws on the length changing operations of [List]. 8 * Mixin that throws on the length changing operations of [List].
9 * 9 *
10 * Intended to mix-in on top of [ListMixin] for fixed-length lists. 10 * Intended to mix-in on top of [ListMixin] for fixed-length lists.
(...skipping 331 matching lines...) Expand 10 before | Expand all | Expand 10 after
342 342
343 /** Error thrown when trying to change the length of an non-growable list. */ 343 /** Error thrown when trying to change the length of an non-growable list. */
344 static UnsupportedError length() 344 static UnsupportedError length()
345 => new UnsupportedError("Cannot change length of non-growable List"); 345 => new UnsupportedError("Cannot change length of non-growable List");
346 346
347 /** Error thrown when trying to remove elements from an non-growable list. */ 347 /** Error thrown when trying to remove elements from an non-growable list. */
348 static UnsupportedError remove() 348 static UnsupportedError remove()
349 => new UnsupportedError("Cannot remove from non-growable List"); 349 => new UnsupportedError("Cannot remove from non-growable List");
350 } 350 }
351 351
352 @patch 352 /**
353 * Converts a growable list to a fixed length list with the same elements.
354 *
355 * For internal use only.
356 * Only works on growable lists as created by `[]` or `new List()`.
357 * May throw on any other list.
358 *
359 * The operation is efficient. It doesn't copy the elements, but converts
360 * the existing list directly to a fixed length list.
361 * That means that it is a destructive conversion.
362 * The original list should not be used afterwards.
363 *
364 * The returned list may be the same list as the orginal,
365 * or it may be a different list (according to [identical]).
366 * The original list may have changed type to be a fixed list,
367 * or become empty or been otherwise modified.
368 * It will still be a valid object, so references to it will not, e.g., crash
369 * the runtime if accessed, but no promises are made wrt. its contents.
370 *
371 * This unspecified behavior is the reason the function is not exposed to
372 * users. We allow the underlying implementation to make the most efficient
373 * conversion, at the cost of leaving the original list in an unspecified
374 * state.
375 */
353 List makeListFixedLength(List growableList) { 376 List makeListFixedLength(List growableList) {
354 JSArray.markFixedList(growableList); 377 JSArray.markFixedList(growableList);
355 return growableList; 378 return growableList;
356 } 379 }
OLDNEW
« no previous file with comments | « test/generated_sdk/lib/core/uri.dart ('k') | test/generated_sdk/lib/internal/print.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698