Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 959873002: Clean up ColorRectProc plumbing. (Closed)

Created:
5 years, 9 months ago by mtklein_C
Modified:
5 years, 9 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Clean up ColorRectProc plumbing. We've always been using the portable ColorRect32, so we don't need the ColorRectProc plumbing. Furthermore, ColorRect32 doesn't seem to be very important (we're only using it in the opaque case, which our row-by-row procs already specialize for). Remove that too. If we find we want specialization for really narrow rects again, let's put it in blitRect() directly. It's pretty unlikely we're going to get platform-specific speedup for blits to non-contiguous memory. My local SKP comparison is +- 3%... most neutral I've ever seen. BUG=skia: Committed: https://skia.googlesource.com/skia/+/edeccc58606e0421a1ae275e391ee4347c6f52f6

Patch Set 1 #

Patch Set 2 : simpler, platform procs specialize anyway #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -120 lines) Patch
M include/core/SkBlitRow.h View 2 chunks +1 line, -12 lines 0 comments Download
M src/core/SkBlitRow_D32.cpp View 2 chunks +0 lines, -83 lines 0 comments Download
M src/core/SkBlitter_ARGB32.cpp View 1 2 chunks +3 lines, -8 lines 0 comments Download
M src/core/SkCoreBlitters.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/opts/SkBlitRow_opts_arm.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M src/opts/SkBlitRow_opts_mips_dsp.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M src/opts/SkBlitRow_opts_none.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M src/opts/opts_check_x86.cpp View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
mtklein_C
5 years, 9 months ago (2015-02-25 20:29:15 UTC) #2
reed1
lgtm
5 years, 9 months ago (2015-02-25 20:38:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/959873002/20001
5 years, 9 months ago (2015-02-25 20:40:13 UTC) #5
commit-bot: I haz the power
5 years, 9 months ago (2015-02-25 20:53:01 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/edeccc58606e0421a1ae275e391ee4347c6f52f6

Powered by Google App Engine
This is Rietveld 408576698