Update the Linux.GlibcVersion histogram to handle glibc 2.2x.

Update the Linux.GlibcVersion histogram to handle glibc 2.2x.

Committed: https://crrev.com/1d7a6fe63bcf2373c1bfce4cb641bd19d413a58a
Cr-Commit-Position: refs/heads/master@{#318161}

[Lei Zhang, 2015-02-25 20:26:02]

thestig@chromium.org changed reviewers:
+ asvitkine@chromium.org

[Alexei Svitkine (slow), 2015-02-25 20:28:50]

asvitkine@chromium.org changed reviewers:
+ rkaplow@chromium.org

[Alexei Svitkine (slow), 2015-02-25 20:28:50]

https://codereview.chromium.org/959863004/diff/1/chrome/browser/metrics/chrom...
File chrome/browser/metrics/chrome_browser_main_extra_parts_metrics.cc (right):

https://codereview.chromium.org/959863004/diff/1/chrome/browser/metrics/chrom...
chrome/browser/metrics/chrome_browser_main_extra_parts_metrics.cc:143:
UMA_HISTOGRAM_ENUMERATION("Linux.GlibcVersion", glibc_version_result,
Perhaps it would be better to use UMA_HISTOGRAM_SPARSE_SLOWLY() here? and also
remove the check for translated_glibc_minor_version <= UMA_LINUX_GLIBC_2_29?

That way, clients can log newer versions and all you need in the future is to
update histograms.xml mapping to see newer data on dashboard.

[Lei Zhang, 2015-02-25 22:13:26]

https://codereview.chromium.org/959863004/diff/1/chrome/browser/metrics/chrom...
File chrome/browser/metrics/chrome_browser_main_extra_parts_metrics.cc (right):

https://codereview.chromium.org/959863004/diff/1/chrome/browser/metrics/chrom...
chrome/browser/metrics/chrome_browser_main_extra_parts_metrics.cc:143:
UMA_HISTOGRAM_ENUMERATION("Linux.GlibcVersion", glibc_version_result,
On 2015/02/25 20:28:50, Alexei Svitkine wrote:
> Perhaps it would be better to use UMA_HISTOGRAM_SPARSE_SLOWLY() here? and also
> remove the check for translated_glibc_minor_version <= UMA_LINUX_GLIBC_2_29?
> 
> That way, clients can log newer versions and all you need in the future is to
> update histograms.xml mapping to see newer data on dashboard.

Done.

[Alexei Svitkine (slow), 2015-02-25 22:14:57]

lgtm

[Lei Zhang, 2015-02-25 22:15:10]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2015-02-25 22:16:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/959863004/20001

[commit-bot: I haz the power, 2015-02-26 00:41:39]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-02-26 00:43:05]

Patchset 2 (id:??) landed as
https://crrev.com/1d7a6fe63bcf2373c1bfce4cb641bd19d413a58a
Cr-Commit-Position: refs/heads/master@{#318161}