Update the Linux.GlibcVersion histogram to handle glibc 2.2x.

chrome/browser/metrics/chrome_browser_main_extra_parts_metrics.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/metrics/chrome_browser_main_extra_parts_metrics.h"
 
 #include <string>
 
 #include "base/bind.h"
 #include "base/command_line.h"
@@ skipping 27 matching lines @@
 #if defined(OS_WIN)
 #include "chrome/installer/util/google_update_settings.h"
 #endif  // defined(OS_WIN)
 
 namespace {
 
 enum UMALinuxGlibcVersion {
   UMA_LINUX_GLIBC_NOT_PARSEABLE,
   UMA_LINUX_GLIBC_UNKNOWN,
   UMA_LINUX_GLIBC_2_11,
-  UMA_LINUX_GLIBC_2_19 = UMA_LINUX_GLIBC_2_11 + 8,
+  UMA_LINUX_GLIBC_2_29 = UMA_LINUX_GLIBC_2_11 + 18,
   // NOTE: Add new version above this line and update the enum list in
   // tools/metrics/histograms/histograms.xml accordingly.
   UMA_LINUX_GLIBC_VERSION_COUNT
 };
 
 enum UMALinuxWindowManager {
   UMA_LINUX_WINDOW_MANAGER_OTHER,
   UMA_LINUX_WINDOW_MANAGER_BLACKBOX,
   UMA_LINUX_WINDOW_MANAGER_CHROME_OS,  // Deprecated.
   UMA_LINUX_WINDOW_MANAGER_COMPIZ,
@@ skipping 68 matching lines @@
     glibc_version_result = UMA_LINUX_GLIBC_UNKNOWN;
     int glibc_major_version = version.components()[0];
     int glibc_minor_version = version.components()[1];
     if (glibc_major_version == 2) {
       // A constant to translate glibc 2.x minor versions to their
       // equivalent UMALinuxGlibcVersion values.
       const int kGlibcMinorVersionTranslationOffset = 11 - UMA_LINUX_GLIBC_2_11;
       int translated_glibc_minor_version =
           glibc_minor_version - kGlibcMinorVersionTranslationOffset;
       if (translated_glibc_minor_version >= UMA_LINUX_GLIBC_2_11 &&
-          translated_glibc_minor_version <= UMA_LINUX_GLIBC_2_19) {
+          translated_glibc_minor_version <= UMA_LINUX_GLIBC_2_29) {
         glibc_version_result =
             static_cast<UMALinuxGlibcVersion>(translated_glibc_minor_version);
       }
     }
   }
   UMA_HISTOGRAM_ENUMERATION("Linux.GlibcVersion", glibc_version_result,

[Alexei Svitkine (slow), 2015/02/25 20:28:50]

Perhaps it would be better to use UMA_HISTOGRAM_SPARSE_SLOWLY() here? and also
remove the check for translated_glibc_minor_version <= UMA_LINUX_GLIBC_2_29?

That way, clients can log newer versions and all you need in the future is to
update histograms.xml mapping to see newer data on dashboard.

[Lei Zhang, 2015/02/25 22:13:26]

Done.

                             UMA_LINUX_GLIBC_VERSION_COUNT);
 #endif
 }
 
 #if defined(USE_X11) && !defined(OS_CHROMEOS)
 UMALinuxWindowManager GetLinuxWindowManager() {
   switch (ui::GuessWindowManager()) {
     case ui::WM_UNKNOWN:
       return UMA_LINUX_WINDOW_MANAGER_OTHER;
     case ui::WM_AWESOME:
@@ skipping 145 matching lines @@
   }
 }
 
 namespace chrome {
 
 void AddMetricsExtraParts(ChromeBrowserMainParts* main_parts) {
   main_parts->AddParts(new ChromeBrowserMainExtraPartsMetrics());
 }
 
 }  // namespace chrome