Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(540)

Issue 959743002: Account for HTTP/2 padding in receive windows. (Closed)

Created:
5 years, 10 months ago by Bence
Modified:
5 years, 9 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Account for HTTP/2 padding in receive windows. Account for pad length field and padding in HTTP/2 session and stream receive windows, because they are part of the payload. This CL introduces a new method OnStreamPadding, calls it when processing padding, implements it to update the receive windows appropriately (both for session and for stream), and adds trivial implementations for all subclasses. This CL also lands internal changes 88830613 and 89327497 by bnc and 89034703 by mpw. BUG=353012 Committed: https://crrev.com/43cdf67d11deda1a4ccca51e44a5183bda93b245 Cr-Commit-Position: refs/heads/master@{#322137}

Patch Set 1 #

Patch Set 2 : Nit. #

Total comments: 1

Patch Set 3 : Rebase. #

Patch Set 4 : Total rewrite. #

Patch Set 5 : Remove redundant DCHECK. #

Patch Set 6 : One more mock implementation. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+161 lines, -25 lines) Patch
M net/quic/quic_headers_stream.cc View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M net/quic/quic_headers_stream_test.cc View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M net/spdy/buffered_spdy_framer.h View 1 2 3 2 chunks +6 lines, -0 lines 0 comments Download
M net/spdy/buffered_spdy_framer.cc View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M net/spdy/buffered_spdy_framer_unittest.cc View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M net/spdy/mock_spdy_framer_visitor.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M net/spdy/spdy_framer.h View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M net/spdy/spdy_framer.cc View 1 2 3 2 chunks +5 lines, -5 lines 0 comments Download
M net/spdy/spdy_framer_test.cc View 1 2 3 6 chunks +22 lines, -10 lines 0 comments Download
M net/spdy/spdy_session.h View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
M net/spdy/spdy_session.cc View 1 2 3 4 2 chunks +19 lines, -8 lines 0 comments Download
M net/spdy/spdy_session_unittest.cc View 1 2 1 chunk +40 lines, -0 lines 0 comments Download
M net/spdy/spdy_stream.h View 2 chunks +6 lines, -2 lines 0 comments Download
M net/spdy/spdy_stream.cc View 1 2 1 chunk +11 lines, -0 lines 0 comments Download
M net/spdy/spdy_test_util_common.h View 1 chunk +7 lines, -0 lines 0 comments Download
M net/spdy/spdy_test_util_common.cc View 1 2 3 2 chunks +13 lines, -0 lines 0 comments Download
M net/tools/flip_server/spdy_interface.h View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M net/tools/flip_server/spdy_interface.cc View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M net/tools/flip_server/spdy_interface_test.cc View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Bence
Ryan: PTAL. Thanks.
5 years, 10 months ago (2015-02-25 18:52:12 UTC) #2
Ryan Hamilton
I think this is basically fine, but I'm not in love with the SpdyFramer's interaction ...
5 years, 10 months ago (2015-02-25 21:59:15 UTC) #3
Bence
Ryan, PTAL. Thanks.
5 years, 9 months ago (2015-03-24 15:54:40 UTC) #4
Ryan Hamilton
lgtm
5 years, 9 months ago (2015-03-24 19:26:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/959743002/100001
5 years, 9 months ago (2015-03-25 11:00:00 UTC) #7
commit-bot: I haz the power
Committed patchset #6 (id:100001)
5 years, 9 months ago (2015-03-25 11:33:51 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-25 11:34:24 UTC) #9
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/43cdf67d11deda1a4ccca51e44a5183bda93b245
Cr-Commit-Position: refs/heads/master@{#322137}

Powered by Google App Engine
This is Rietveld 408576698