Account for HTTP/2 padding in receive windows.

net/spdy/spdy_framer.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/spdy/spdy_framer.h"
 
 #include "base/lazy_instance.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/third_party/valgrind/memcheck.h"
 #include "net/spdy/spdy_frame_builder.h"
@@ skipping 2137 matching lines @@
 }
 
 size_t SpdyFramer::ProcessDataFramePaddingLength(const char* data, size_t len) {
   DCHECK_EQ(SPDY_READ_DATA_FRAME_PADDING_LENGTH, state_);
   DCHECK_EQ(0u, remaining_padding_payload_length_);
   DCHECK_EQ(DATA, current_frame_type_);
 
   size_t original_len = len;
   if (current_frame_flags_ & DATA_FLAG_PADDED) {
     if (len != 0) {
+      static_assert(kPadLengthFieldSize == 1,
+                    "Unexpected pad length field size.");
       if (remaining_data_length_ < kPadLengthFieldSize) {
         set_error(SPDY_INVALID_DATA_FRAME_FLAGS);
         return 0;
       }
 
       remaining_padding_payload_length_ = *reinterpret_cast<const uint8*>(data);
       ++data;
       --len;
       --remaining_data_length_;
+
+      // Notify visitor that |kPadLengthFieldSize| bytes of payload are
+      // consumed.
+      visitor_->OnStreamFrameData(current_frame_stream_id_, NULL,
+                                  kPadLengthFieldSize, false);

[Ryan Hamilton, 2015/02/25 21:59:15]

Should this change land internally first? In any case, I'm not in love with this
approach. I think I'd prefer either:
1) and explicit OnStreamPadding() or
2) and extra size_t num_padding_bytes argument to OnStreamFrameData()

     } else {
       // We don't have the data available for parsing the pad length field. Keep
       // waiting.
       return 0;
     }
   }
 
   if (remaining_padding_payload_length_ > remaining_data_length_) {
     set_error(SPDY_INVALID_DATA_FRAME_FLAGS);
     return 0;
@@ skipping 1100 matching lines @@
 #else
   WriteHeaderBlockToZ(&frame.name_value_block(), compressor);
 #endif  // defined(USE_SYSTEM_ZLIB)
 
   int compressed_size = compressed_max_size - compressor->avail_out;
   builder->Seek(compressed_size);
   builder->RewriteLength(*this);
 }
 
 }  // namespace net