Issue 959543002: Simplify and reduce calls to beginTransparencyLayers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 959543002: Simplify and reduce calls to beginTransparencyLayers. (Closed)

Created:
5 years, 10 months ago by ojan

Modified:
5 years, 10 months ago

Reviewers:
abarth-chromium

CC:
abarth-chromium, esprehn, mojo-reviews_chromium.org, qsr+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Simplify and reduce calls to beginTransparencyLayers. -Consolidate the beginTransparencyLayers calls. The call on layer()->parent() was just not needed as best I can tell and the filter one could just be shared with the non-filter codepath. FWIW, blink has already made a similar set of changes. -Don't walk up the tree calling beginTransparencyLayer. We're doing this in a recursive call down, so we've already created the transparency layer for any transparent ancestors. -Remove unused TransparencyClipBoxMode argument. -Inline the paintingExtent method. -Removed unused REVEAL_TRANSPARENCY_LAYERS #define. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/b80fcd4edf8b6ad99a644a9174671fa889758422

Patch Set 1 #

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+23 lines, -109 lines)			Patch
M	sky/engine/core/rendering/LayerPaintingInfo.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	sky/engine/core/rendering/RenderBox.cpp	View	5 chunks	+8 lines, -48 lines	0 comments	Download
M	sky/engine/core/rendering/RenderLayer.h	View	3 chunks	+0 lines, -9 lines	0 comments	Download
M	sky/engine/core/rendering/RenderLayer.cpp	View	3 chunks	+15 lines, -50 lines	0 comments	Download

Messages

Total messages: 3 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

ojan

5 years, 10 months ago (2015-02-25 01:29:05 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
b80fcd4edf8b6ad99a644a9174671fa889758422 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages