sky/engine/core/rendering/RenderLayer.h - Issue 959543002: Simplify and reduce calls to beginTransparencyLayers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/core/rendering/RenderLayer.h

Issue 959543002: Simplify and reduce calls to beginTransparencyLayers. (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/engine/core/rendering/RenderLayer.h

diff --git a/sky/engine/core/rendering/RenderLayer.h b/sky/engine/core/rendering/RenderLayer.h

index a49b8350f86f65b4cf06f99d7bdc4ea47405ec1e..5742a77673e8f1412b0eb1344fc818d1741c1727 100644

--- a/sky/engine/core/rendering/RenderLayer.h

+++ b/sky/engine/core/rendering/RenderLayer.h

@@ -131,9 +131,6 @@ public:

// True if this layer container renderers that paint.

bool hasNonEmptyChildRenderers() const;

- bool usedTransparency() const { return m_usedTransparency; }

- void clearUsedTransparency() { m_usedTransparency = false; }

// Gets the nearest enclosing positioned ancestor layer (also includes

// the <html> layer and the root layer).

RenderLayer* enclosingPositionedAncestor() const;

@@ -267,8 +264,6 @@ private:

void updateOrRemoveFilterClients();

- LayoutRect paintingExtent(const RenderLayer* rootLayer, const LayoutRect& paintDirtyRect, const LayoutSize& subPixelAccumulation);

LayerType m_layerType;

// Self-painting layer is an optimization where we avoid the heavy RenderLayer painting

@@ -283,10 +278,6 @@ private:

const unsigned m_isRootLayer : 1;

- unsigned m_usedTransparency : 1; // Tracks whether we need to close a transparent layer, i.e., whether

- // we ended up painting this layer or any descendants (and therefore need to

- // blend).

unsigned m_3DTransformedDescendantStatusDirty : 1;

// Set on a stacking context layer that has 3D descendants anywhere

// in a preserves3D hierarchy. Hint to do 3D-aware hit testing.

« no previous file with comments | « sky/engine/core/rendering/RenderBox.cpp ('k') | sky/engine/core/rendering/RenderLayer.cpp » ('j') | no next file with comments »