Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(117)

Issue 959443003: Fix left/right keyboard scrolling in PDFs (Closed)

Created:
5 years, 4 months ago by raymes
Modified:
5 years, 4 months ago
Reviewers:
Sam McNally
CC:
chromium-reviews, arv+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix left/right keyboard scrolling in PDFs Non-existent dictionary members were trying to be accessed. BUG=461587 Committed: https://crrev.com/7593306a8770d5fd7d884532a6dd012df55b4d7f Cr-Commit-Position: refs/heads/master@{#317935}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/resources/pdf/pdf.js View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
raymes
5 years, 4 months ago (2015-02-24 23:50:48 UTC) #2
Sam McNally
lgtm
5 years, 4 months ago (2015-02-24 23:57:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/959443003/1
5 years, 4 months ago (2015-02-24 23:58:30 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-02-25 01:05:15 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-02-25 01:05:35 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7593306a8770d5fd7d884532a6dd012df55b4d7f
Cr-Commit-Position: refs/heads/master@{#317935}

Powered by Google App Engine
This is Rietveld 408576698