Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Unified Diff: extensions/common/user_script.cc

Issue 959413003: Implement <webview>.addContentScript/removeContentScript API [1] (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add comments. Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/common/user_script.cc
diff --git a/extensions/common/user_script.cc b/extensions/common/user_script.cc
index ea7b6a7423edbbc9ffdd2b4dd64412d3f66ae2e2..825276fd019bc8fde2f0a862b93d901b5b4e8563 100644
--- a/extensions/common/user_script.cc
+++ b/extensions/common/user_script.cc
@@ -147,7 +147,6 @@ void UserScript::Pickle(::Pickle* pickle) const {
PickleHostID(pickle, host_id_);
pickle->WriteInt(consumer_instance_type());
- PickleRoutingInfo(pickle, routing_info_);
PickleGlobs(pickle, globs_);
PickleGlobs(pickle, exclude_globs_);
PickleURLPatternSet(pickle, url_set_);
@@ -170,12 +169,6 @@ void UserScript::PickleHostID(::Pickle* pickle, const HostID& host_id) const {
pickle->WriteString(host_id.id());
}
-void UserScript::PickleRoutingInfo(::Pickle* pickle,
- const RoutingInfo& routing_info) const {
- pickle->WriteInt(routing_info.render_process_id);
- pickle->WriteInt(routing_info.render_view_id);
-}
-
void UserScript::PickleURLPatternSet(::Pickle* pickle,
const URLPatternSet& pattern_list) const {
pickle->WriteSizeT(pattern_list.patterns().size());
@@ -215,7 +208,6 @@ void UserScript::Unpickle(const ::Pickle& pickle, PickleIterator* iter) {
consumer_instance_type_ =
static_cast<ConsumerInstanceType>(consumer_instance_type);
- UnpickleRoutingInfo(pickle, iter, &routing_info_);
UnpickleGlobs(pickle, iter, &globs_);
UnpickleGlobs(pickle, iter, &exclude_globs_);
UnpickleURLPatternSet(pickle, iter, &url_set_);
@@ -246,13 +238,6 @@ void UserScript::UnpickleHostID(const ::Pickle& pickle,
*host_id = HostID(static_cast<HostID::HostType>(type), id);
}
-void UserScript::UnpickleRoutingInfo(const ::Pickle& pickle,
- PickleIterator* iter,
- RoutingInfo* routing_info) {
- CHECK(iter->ReadInt(&routing_info->render_process_id));
- CHECK(iter->ReadInt(&routing_info->render_view_id));
-}
-
void UserScript::UnpickleURLPatternSet(const ::Pickle& pickle,
PickleIterator* iter,
URLPatternSet* pattern_list) {

Powered by Google App Engine
This is Rietveld 408576698