extensions/common/extension_messages.h - Issue 959413003: Implement <webview>.addContentScript/removeContentScript API [1]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/common/extension_messages.h

Issue 959413003: Implement <webview>.addContentScript/removeContentScript API [1] (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add comments. Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« extensions/browser/guest_view/web_view/web_view_renderer_state.cc ('K') | « extensions/common/api/web_view_internal.json ('k') | extensions/common/guest_view/guest_view_messages.h » ('j') | extensions/renderer/user_script_set_manager.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/common/extension_messages.h

diff --git a/extensions/common/extension_messages.h b/extensions/common/extension_messages.h

index 73adbcd204d4e0002e31d6b23acfcab0e40c429d..1cbef89f98213f589e1e80f46a2998aa777ced00 100644

--- a/extensions/common/extension_messages.h

+++ b/extensions/common/extension_messages.h

@@ -457,10 +457,13 @@ IPC_MESSAGE_ROUTED1(ExtensionMsg_ExecuteCode,

// region will be updated. Note that the empty set => all hosts case is not

// supported for per-extension programmatically-defined script regions; in such

// regions, the owner is expected to list itself as the only changed host.

-IPC_MESSAGE_CONTROL3(ExtensionMsg_UpdateUserScripts,

+// |is_to_guest_render_process| indicates whether the IPC is sent to a guest

Fady Samuel 2015/04/02 21:46:09 nit: is_guest_process is less wordy

+// render process.

+IPC_MESSAGE_CONTROL4(ExtensionMsg_UpdateUserScripts,

base::SharedMemoryHandle,

HostID /* owner */,

- std::set<HostID> /* changed hosts */)

+ std::set<HostID> /* changed hosts */,

+ bool /* is to a guest render process */)

// Trigger to execute declarative content script under browser control.

IPC_MESSAGE_ROUTED4(ExtensionMsg_ExecuteDeclarativeScript,