Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(401)

Issue 959343004: Move InMemoryURLIndex outside of history namespace (Closed)

Created:
5 years, 9 months ago by sdefresne
Modified:
5 years, 9 months ago
Reviewers:
Jay Civelli, Mark P
CC:
chromium-reviews, James Su, browser-components-watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@in-memory-url-index
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move InMemoryURLIndex outside of history namespace Since InMemoryURLIndex code is no longer in chrome/browser/history but instead in chrome/browser/autocomplete, move it out of the history namespace. BUG=453790 TBR=jcivelli@chromium.org Committed: https://crrev.com/b21674ab2d2f875c4d011f43835e63eb262b2fa4 Cr-Commit-Position: refs/heads/master@{#319655}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+301 lines, -337 lines) Patch
M chrome/browser/autocomplete/history_provider.h View 1 chunk +3 lines, -4 lines 0 comments Download
M chrome/browser/autocomplete/history_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/history_quick_provider.h View 2 chunks +5 lines, -11 lines 0 comments Download
M chrome/browser/autocomplete/history_quick_provider.cc View 3 chunks +2 lines, -6 lines 0 comments Download
M chrome/browser/autocomplete/history_quick_provider_unittest.cc View 2 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/autocomplete/history_url_provider.cc View 1 2 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/browser/autocomplete/in_memory_url_index.h View 1 6 chunks +10 lines, -13 lines 0 comments Download
M chrome/browser/autocomplete/in_memory_url_index.cc View 7 chunks +8 lines, -11 lines 0 comments Download
M chrome/browser/autocomplete/in_memory_url_index_types.h View 4 chunks +3 lines, -11 lines 0 comments Download
M chrome/browser/autocomplete/in_memory_url_index_types.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/autocomplete/in_memory_url_index_types_unittest.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/browser/autocomplete/in_memory_url_index_unittest.cc View 14 chunks +21 lines, -21 lines 0 comments Download
M chrome/browser/autocomplete/scored_history_match.h View 4 chunks +3 lines, -7 lines 0 comments Download
M chrome/browser/autocomplete/scored_history_match.cc View 2 chunks +1 line, -5 lines 0 comments Download
M chrome/browser/autocomplete/scored_history_match_builder_impl.h View 4 chunks +17 lines, -19 lines 0 comments Download
M chrome/browser/autocomplete/scored_history_match_builder_impl.cc View 8 chunks +24 lines, -29 lines 0 comments Download
M chrome/browser/autocomplete/scored_history_match_builder_impl_unittest.cc View 16 chunks +71 lines, -73 lines 0 comments Download
M chrome/browser/autocomplete/url_index_private_data.h View 10 chunks +41 lines, -32 lines 0 comments Download
M chrome/browser/autocomplete/url_index_private_data.cc View 26 chunks +61 lines, -61 lines 0 comments Download
M chrome/browser/history/history_service.h View 1 2 5 chunks +5 lines, -7 lines 0 comments Download
M chrome/browser/history/history_service.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/history_index_restore_observer.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/testing_profile.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/history/core/browser/history_database.h View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
sdefresne
This is the first followup to https://codereview.chromium.org/963823003/ to move the code out of the history ...
5 years, 9 months ago (2015-02-27 18:37:18 UTC) #2
Mark P
lgtm https://codereview.chromium.org/959343004/diff/1/chrome/browser/autocomplete/history_url_provider.cc File chrome/browser/autocomplete/history_url_provider.cc (right): https://codereview.chromium.org/959343004/diff/1/chrome/browser/autocomplete/history_url_provider.cc#newcode712 chrome/browser/autocomplete/history_url_provider.cc:712: &description_word_starts); nit: I think this fits in one ...
5 years, 9 months ago (2015-02-27 20:57:57 UTC) #3
sdefresne
Thank you for the review. https://codereview.chromium.org/959343004/diff/1/chrome/browser/autocomplete/history_url_provider.cc File chrome/browser/autocomplete/history_url_provider.cc (right): https://codereview.chromium.org/959343004/diff/1/chrome/browser/autocomplete/history_url_provider.cc#newcode712 chrome/browser/autocomplete/history_url_provider.cc:712: &description_word_starts); almost, it is ...
5 years, 9 months ago (2015-03-02 08:54:14 UTC) #4
sdefresne
+jcivelli: OWNERS of chrome/test/base/history_index_restore_observer.h chrome/test/base/testing_profile.cc Will TBR those changes as they are mechanical (removing history:: ...
5 years, 9 months ago (2015-03-09 16:24:31 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/959343004/40001
5 years, 9 months ago (2015-03-09 16:53:56 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 9 months ago (2015-03-09 16:59:48 UTC) #10
commit-bot: I haz the power
5 years, 9 months ago (2015-03-09 17:08:46 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/b21674ab2d2f875c4d011f43835e63eb262b2fa4
Cr-Commit-Position: refs/heads/master@{#319655}

Powered by Google App Engine
This is Rietveld 408576698