chrome/browser/autocomplete/history_url_provider.cc - Issue 959343004: Move InMemoryURLIndex outside of history namespace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/autocomplete/history_url_provider.cc

Issue 959343004: Move InMemoryURLIndex outside of history namespace (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@in-memory-url-index

Patch Set: Rebase Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/autocomplete/history_quick_provider_unittest.cc ('k') | chrome/browser/autocomplete/in_memory_url_index.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/autocomplete/history_url_provider.cc

diff --git a/chrome/browser/autocomplete/history_url_provider.cc b/chrome/browser/autocomplete/history_url_provider.cc

index 4b865e798319234676cc63590c60737fd9f510a5..1bf3261506f3a586de739be2b2c8b6aa1bfbe920 100644

--- a/chrome/browser/autocomplete/history_url_provider.cc

+++ b/chrome/browser/autocomplete/history_url_provider.cc

@@ -706,14 +706,14 @@ ACMatchClassifications HistoryURLProvider::ClassifyDescription(

const base::string16& description) {

base::string16 clean_description =

bookmarks::CleanUpTitleForMatching(description);

- history::TermMatches description_matches(SortAndDeoverlapMatches(

- history::MatchTermInString(input_text, clean_description, 0)));

- history::WordStarts description_word_starts;

- history::String16VectorFromString16(

- clean_description, false, &description_word_starts);

+ TermMatches description_matches(SortAndDeoverlapMatches(

+ MatchTermInString(input_text, clean_description, 0)));

+ WordStarts description_word_starts;

+ String16VectorFromString16(clean_description, false,

+ &description_word_starts);

// If HistoryURL retrieves any matches (and hence we reach this code), we

// are guaranteed that the beginning of input_text must be a word break.

- history::WordStarts offsets(1, 0u);

+ WordStarts offsets(1, 0u);

description_matches =

ScoredHistoryMatchBuilderImpl::FilterTermMatchesByWordStarts(

description_matches, offsets, description_word_starts, 0,