Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(903)

Unified Diff: cc/layers/layer_impl.h

Issue 958843004: Fix for 424682: Draw correct repaint regions instead of a conservative bounding box (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/layers/layer_impl.h
diff --git a/cc/layers/layer_impl.h b/cc/layers/layer_impl.h
index 5de0d9a8845c1945d9ce9d6ab06b63b022186872..de5aba7abb9487ef85199ff48a459b0e9ed61425 100644
--- a/cc/layers/layer_impl.h
+++ b/cc/layers/layer_impl.h
@@ -596,6 +596,11 @@ class CC_EXPORT LayerImpl : public LayerAnimationValueObserver,
SyncedScrollOffset* synced_scroll_offset() { return scroll_offset_.get(); }
+ // Get the correct invalidation region instead of conservative Rect for
+ // layers that can provide it (e.g. picture_layer_imp.h)
danakj 2015/02/26 23:53:05 drop the reference to picture_layer_imp.h here I t
daplatz 2015/02/27 11:04:56 Acknowledged.
+ // Used by debug_rect_history.h to track repaint regions.
danakj 2015/02/26 23:53:05 Listing callers of functions is sure to go wrong,
daplatz 2015/02/27 11:04:56 Acknowledged.
+ virtual Region GetInvalidationRegion() { return Region(update_rect_); };
danakj 2015/02/26 23:53:05 virtual function bodies must be in the .cc file (t
daplatz 2015/02/27 11:04:56 Acknowledged.
+
protected:
LayerImpl(LayerTreeImpl* layer_impl,
int id,

Powered by Google App Engine
This is Rietveld 408576698