Fix for 424682: Draw correct repaint regions instead of a conservative bounding box

cc/layers/layer_impl.h

 // Copyright 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CC_LAYERS_LAYER_IMPL_H_
 #define CC_LAYERS_LAYER_IMPL_H_
 
 #include <set>
 #include <string>
 #include <vector>
@@ skipping 578 matching lines @@
   int sorting_context_id() { return sorting_context_id_; }
 
   void PassFrameTimingRequests(
       std::vector<FrameTimingRequest>* frame_timing_requests);
   const std::vector<FrameTimingRequest>& frame_timing_requests() const {
     return frame_timing_requests_;
   }
 
   SyncedScrollOffset* synced_scroll_offset() { return scroll_offset_.get(); }
 
+  // Get the correct invalidation region instead of conservative Rect for
+  // layers that can provide it (e.g. picture_layer_imp.h)

[danakj, 2015/02/26 23:53:05]

drop the reference to picture_layer_imp.h here I think.

[daplatz, 2015/02/27 11:04:56]

Acknowledged.

+  // Used by debug_rect_history.h to track repaint regions.

[danakj, 2015/02/26 23:53:05]

Listing callers of functions is sure to go wrong, we can find callsites from
code search, so I think just remove this too.

[daplatz, 2015/02/27 11:04:56]

Acknowledged.

+  virtual Region GetInvalidationRegion() { return Region(update_rect_); };

[danakj, 2015/02/26 23:53:05]

virtual function bodies must be in the .cc file (this won't compile with clang)

[daplatz, 2015/02/27 11:04:56]

Acknowledged.

+
  protected:
   LayerImpl(LayerTreeImpl* layer_impl,
             int id,
             scoped_refptr<SyncedScrollOffset> scroll_offset);
   LayerImpl(LayerTreeImpl* layer_impl, int id);
 
   // Get the color and size of the layer's debug border.
   virtual void GetDebugBorderProperties(SkColor* color, float* width) const;
 
   void AppendDebugBorderQuad(RenderPass* render_pass,
@@ skipping 153 matching lines @@
 
   std::vector<FrameTimingRequest> frame_timing_requests_;
   bool frame_timing_requests_dirty_;
 
   DISALLOW_COPY_AND_ASSIGN(LayerImpl);
 };
 
 }  // namespace cc
 
 #endif  // CC_LAYERS_LAYER_IMPL_H_