Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Unified Diff: pkg/compiler/lib/src/js_backend/codegen/codegen.dart

Issue 958603002: Added VariableUse expression to tree IR. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/js_backend/codegen/codegen.dart
diff --git a/pkg/compiler/lib/src/js_backend/codegen/codegen.dart b/pkg/compiler/lib/src/js_backend/codegen/codegen.dart
index b1f03bfd730a7d0ba27a186869a9f6320274ff53..11f239b3e9fd4c9a491160ba47ab1cc4f31685f2 100644
--- a/pkg/compiler/lib/src/js_backend/codegen/codegen.dart
+++ b/pkg/compiler/lib/src/js_backend/codegen/codegen.dart
@@ -345,8 +345,12 @@ class CodeGenerator extends tree_ir.Visitor<dynamic, js.Expression> {
}
@override
- js.Expression visitVariable(tree_ir.Variable node) {
- return new js.VariableUse(getVariableName(node));
+ js.Expression visitVariableUse(tree_ir.VariableUse node) {
+ return visitVariable(node.variable);
+ }
+
+ js.Expression visitVariable(tree_ir.Variable variable) {
Kevin Millikin (Google) 2015/02/26 12:43:18 Likewise, I'm not sure I'd call this visitVariable
asgerf 2015/02/27 12:05:19 Renamed to buildVariableAccess.
+ return new js.VariableUse(getVariableName(variable));
}
@override

Powered by Google App Engine
This is Rietveld 408576698