Added VariableUse expression to tree IR.

pkg/compiler/lib/src/js_backend/codegen/codegen.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library code_generator;
 
 import 'glue.dart';
 
 import '../../tree_ir/tree_ir_nodes.dart' as tree_ir;
 import '../../js/js.dart' as js;
@@ skipping 327 matching lines @@
     return new js.This();
   }
 
   @override
   js.Expression visitTypeOperator(tree_ir.TypeOperator node) {
     return giveup(node);
     // TODO: implement visitTypeOperator
   }
 
   @override
-  js.Expression visitVariable(tree_ir.Variable node) {
-    return new js.VariableUse(getVariableName(node));
+  js.Expression visitVariableUse(tree_ir.VariableUse node) {
+    return visitVariable(node.variable);
+  }
+
+  js.Expression visitVariable(tree_ir.Variable variable) {

[Kevin Millikin (Google), 2015/02/26 12:43:18]

Likewise, I'm not sure I'd call this visitVariable which suggests that I could
call it for any variable (it depends on the context, it doesn't do the right
thing for FunctionDefinition parameters).  Do we really have a js.VariableUse on
the left-hand side of an assignment?  Crazy.

[asgerf, 2015/02/27 12:05:19]

Renamed to buildVariableAccess.

+    return new js.VariableUse(getVariableName(variable));
   }
 
   @override
   void visitContinue(tree_ir.Continue node) {
     tree_ir.Statement fallthrough = this.fallthrough;
     if (node.target.binding == fallthrough) {
       // Fall through to continue target
     } else if (fallthrough is tree_ir.Continue &&
                fallthrough.target == node.target) {
       // Fall through to equivalent continue
@@ skipping 163 matching lines @@
 
   @override
   visitSuperInitializer(tree_ir.SuperInitializer node) {
     return errorUnsupportedNode(node);
   }
 
   dynamic errorUnsupportedNode(tree_ir.DartSpecificNode node) {
     throw "Unsupported node in JS backend: $node";
   }
 }