Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(676)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 958583003: [x86] Use better left operand heuristic for Float64Add and Float64Mul. (Closed)

Created:
5 years, 10 months ago by Benedikt Meurer
Modified:
5 years, 10 months ago
Reviewers:
dcarney
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[x86] Use better left operand heuristic for Float64Add and Float64Mul. R=dcarney@chromium.org Committed: https://crrev.com/9da259fb1f4ecfefeb2cf7efbe449d8aa1904032 Cr-Commit-Position: refs/heads/master@{#26849}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -16 lines) Patch
M src/compiler/ia32/instruction-selector-ia32.cc View 2 chunks +14 lines, -8 lines 0 comments Download
M src/compiler/x64/instruction-selector-x64.cc View 2 chunks +14 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
Benedikt Meurer
5 years, 10 months ago (2015-02-25 11:49:08 UTC) #1
Benedikt Meurer
PTAL
5 years, 10 months ago (2015-02-25 11:49:34 UTC) #2
dcarney
lgtm no test?
5 years, 10 months ago (2015-02-25 11:50:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/958583003/1
5 years, 10 months ago (2015-02-25 12:01:44 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-25 12:10:03 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/9da259fb1f4ecfefeb2cf7efbe449d8aa1904032 Cr-Commit-Position: refs/heads/master@{#26849}
5 years, 10 months ago (2015-02-25 12:10:19 UTC) #7
Benedikt Meurer
5 years, 9 months ago (2015-03-03 19:16:55 UTC) #8
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/972243002/ by bmeurer@chromium.org.

The reason for reverting is: Tanks on Atom and Haswell.

Powered by Google App Engine
This is Rietveld 408576698