Remove some unnecessary and precision-losing pixel snapping code.

Remove some unnecessary and precision-losing pixel snapping code.


BUG=456885, 461615
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190865

[chrishtr, 2015-02-25 18:28:40]

chrishtr@chromium.org changed reviewers:
+ leviw@chromium.org

[chrishtr, 2015-02-25 18:28:41]

https://codereview.chromium.org/958543004/diff/1/Source/core/layout/LayoutBox...
File Source/core/layout/LayoutBox.cpp (left):

https://codereview.chromium.org/958543004/diff/1/Source/core/layout/LayoutBox...
Source/core/layout/LayoutBox.cpp:1173: LayoutRect backgroundRect =
pixelSnappedIntRect(borderBoxRect());
This one is not necessary because borderBoxRect() always uses a top-left
position of (0,0).

[eae, 2015-02-25 18:32:08]

eae@chromium.org changed reviewers:
+ eae@chromium.org

[eae, 2015-02-25 18:32:09]

LGTM!

[leviw_travelin_and_unemployed, 2015-02-25 18:32:28]

leviw@chromium.org changed reviewers:
- eae@chromium.org

[leviw_travelin_and_unemployed, 2015-02-25 18:32:28]

The CQ bit was checked by leviw@chromium.org

[leviw_travelin_and_unemployed, 2015-02-25 18:32:28]

LGTM.

https://codereview.chromium.org/958543004/diff/1/Source/core/paint/BoxPainter...
File Source/core/paint/BoxPainter.cpp (right):

https://codereview.chromium.org/958543004/diff/1/Source/core/paint/BoxPainter...
Source/core/paint/BoxPainter.cpp:689: geometry.setDestRect(viewportRect);
Can't we pixel snap this just a few more times to be sure? ;)

[leviw_travelin_and_unemployed, 2015-02-25 18:32:29]

The patchset sent to the CQ was uploaded after l-g-t-m from eae@chromium.org
Link to the patchset: https://codereview.chromium.org/958543004/#ps40001 (title:
" ")

[chrishtr, 2015-02-25 18:33:10]

The CQ bit was unchecked by chrishtr@chromium.org

[chrishtr, 2015-02-25 18:33:12]

The CQ bit was checked by chrishtr@chromium.org

[commit-bot: I haz the power, 2015-02-25 18:33:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/958543004/40001

[chrishtr, 2015-02-25 18:38:39]

The CQ bit was unchecked by chrishtr@chromium.org

[chrishtr, 2015-02-25 18:40:32]

chrishtr@chromium.org changed reviewers:
+ eae@chromium.org

[chrishtr, 2015-02-25 18:40:33]

Changed LayoutBox to use enclosingIntRect instead. Pixel snapping did actually
have an
effect, but Levi reported offline it didn't make sense because the location is
always
(0,0).

[chrishtr, 2015-02-25 18:40:36]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2015-02-25 18:40:36]

The patchset sent to the CQ was uploaded after l-g-t-m from leviw@chromium.org,
eae@chromium.org
Link to the patchset: https://codereview.chromium.org/958543004/#ps60001 (title:
" ")

[commit-bot: I haz the power, 2015-02-25 18:41:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/958543004/60001

[chrishtr, 2015-02-25 19:49:05]

The CQ bit was unchecked by chrishtr@chromium.org

[chrishtr, 2015-02-25 19:49:07]

The CQ bit was checked by chrishtr@chromium.org

[commit-bot: I haz the power, 2015-02-25 19:49:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/958543004/60001

[chrishtr, 2015-02-25 19:51:56]

The CQ bit was unchecked by chrishtr@chromium.org

[chrishtr, 2015-02-25 19:53:07]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2015-02-25 19:53:07]

The patchset sent to the CQ was uploaded after l-g-t-m from leviw@chromium.org,
eae@chromium.org
Link to the patchset: https://codereview.chromium.org/958543004/#ps80001 (title:
" ")

[commit-bot: I haz the power, 2015-02-25 19:53:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/958543004/80001

[commit-bot: I haz the power, 2015-02-25 23:04:30]

Committed patchset #5 (id:80001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190865

[Xianzhu, 2015-02-25 23:11:32]

Are the bug numbers correct?

[chrishtr, 2015-02-25 23:12:38]

No. Sorry, fixing.