Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Side by Side Diff: Source/core/layout/LayoutObject.cpp

Issue 958543004: Remove some unnecessary and precision-losing pixel snapping code. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/layout/LayoutBox.cpp ('k') | Source/core/paint/BoxPainter.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2000 Dirk Mueller (mueller@kde.org) 4 * (C) 2000 Dirk Mueller (mueller@kde.org)
5 * (C) 2004 Allan Sandfeld Jensen (kde@carewolf.com) 5 * (C) 2004 Allan Sandfeld Jensen (kde@carewolf.com)
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2011 Apple Inc. All rights reserv ed. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2011 Apple Inc. All rights reserv ed.
7 * Copyright (C) 2009 Google Inc. All rights reserved. 7 * Copyright (C) 2009 Google Inc. All rights reserved.
8 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/) 8 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/)
9 * 9 *
10 * This library is free software; you can redistribute it and/or 10 * This library is free software; you can redistribute it and/or
(...skipping 968 matching lines...) Expand 10 before | Expand all | Expand 10 after
979 IntRect LayoutObject::absoluteBoundingBoxRectIgnoringTransforms() const 979 IntRect LayoutObject::absoluteBoundingBoxRectIgnoringTransforms() const
980 { 980 {
981 FloatPoint absPos = localToAbsolute(); 981 FloatPoint absPos = localToAbsolute();
982 Vector<IntRect> rects; 982 Vector<IntRect> rects;
983 absoluteRects(rects, flooredLayoutPoint(absPos)); 983 absoluteRects(rects, flooredLayoutPoint(absPos));
984 984
985 size_t n = rects.size(); 985 size_t n = rects.size();
986 if (!n) 986 if (!n)
987 return IntRect(); 987 return IntRect();
988 988
989 LayoutRect result = rects[0]; 989 IntRect result = rects[0];
990 for (size_t i = 1; i < n; ++i) 990 for (size_t i = 1; i < n; ++i)
991 result.unite(rects[i]); 991 result.unite(rects[i]);
992 return pixelSnappedIntRect(result); 992 return result;
993 } 993 }
994 994
995 IntRect LayoutObject::absoluteFocusRingBoundingBoxRect() const 995 IntRect LayoutObject::absoluteFocusRingBoundingBoxRect() const
996 { 996 {
997 Vector<LayoutRect> rects; 997 Vector<LayoutRect> rects;
998 const LayoutBoxModelObject* container = enclosingLayer()->renderer(); 998 const LayoutBoxModelObject* container = enclosingLayer()->renderer();
999 addFocusRingRects(rects, LayoutPoint(localToContainerPoint(FloatPoint(), con tainer))); 999 addFocusRingRects(rects, LayoutPoint(localToContainerPoint(FloatPoint(), con tainer)));
1000 return container->localToAbsoluteQuad(FloatQuad(unionRect(rects))).enclosing BoundingBox(); 1000 return container->localToAbsoluteQuad(FloatQuad(unionRect(rects))).enclosing BoundingBox();
1001 } 1001 }
1002 1002
(...skipping 2186 matching lines...) Expand 10 before | Expand all | Expand 10 after
3189 { 3189 {
3190 if (object1) { 3190 if (object1) {
3191 const blink::LayoutObject* root = object1; 3191 const blink::LayoutObject* root = object1;
3192 while (root->parent()) 3192 while (root->parent())
3193 root = root->parent(); 3193 root = root->parent();
3194 root->showRenderTreeAndMark(object1, "*", object2, "-", 0); 3194 root->showRenderTreeAndMark(object1, "*", object2, "-", 0);
3195 } 3195 }
3196 } 3196 }
3197 3197
3198 #endif 3198 #endif
OLDNEW
« no previous file with comments | « Source/core/layout/LayoutBox.cpp ('k') | Source/core/paint/BoxPainter.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698