Issue 958433003: SkPDF: replace SkPDFDevice::copyContentToData

Issue 958433003: SkPDF: replace SkPDFDevice::copyContentToData (Closed)

Created:
5 years, 10 months ago by hal.canary

Modified:
5 years, 10 months ago

Reviewers:
mtklein

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

SkPDF: replace SkPDFDevice::copyContentToData Motivation: remove copyToData(). Later we will stop caching the data alltogether. BUG=skia: Committed: https://skia.googlesource.com/skia/+/334fcbc167237f02058cb508cb5f51b718141461

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+17 lines, -25 lines)			Patch
M	src/pdf/SkPDFDevice.h	View	1 chunk	+4 lines, -7 lines	0 comments	Download
M	src/pdf/SkPDFDevice.cpp	View	4 chunks	+9 lines, -14 lines	0 comments	Download
M	src/pdf/SkPDFFormXObject.cpp	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/pdf/SkPDFPage.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pdf/SkPDFShader.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 12 (4 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/958433003/1

5 years, 10 months ago (2015-02-24 19:48:25 UTC) #2

commit-bot: I haz the power

Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...

5 years, 10 months ago (2015-02-24 19:48:26 UTC) #3

mtklein

lgtm So, the idea is, next thing is remove content() itself? Otherwise, we've just renamed ...

5 years, 10 months ago (2015-02-24 20:04:15 UTC) #7

hal.canary

On 2015/02/24 20:04:15, mtklein wrote: > So, the idea is, next thing is remove content() ...

5 years, 10 months ago (2015-02-24 20:55:39 UTC) #8

mtklein

On 2015/02/24 20:55:39, Hal Canary wrote: > On 2015/02/24 20:04:15, mtklein wrote: > > So, ...

5 years, 10 months ago (2015-02-24 20:55:55 UTC) #10

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/958433003/1

5 years, 10 months ago (2015-02-24 20:56:05 UTC) #11

commit-bot: I haz the power

5 years, 10 months ago (2015-02-24 20:56:20 UTC) #12

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/334fcbc167237f02058cb508cb5f51b718141461