src/pdf/SkPDFPage.cpp - Issue 958433003: SkPDF: replace SkPDFDevice::copyContentToData

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/pdf/SkPDFPage.cpp

Issue 958433003: SkPDF: replace SkPDFDevice::copyContentToData (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/pdf/SkPDFPage.cpp

diff --git a/src/pdf/SkPDFPage.cpp b/src/pdf/SkPDFPage.cpp

index b792f5e365297ac52e1e7e936d5696e55183e0c4..da0179a283563513c7f3921edac589e4684abf24 100644

--- a/src/pdf/SkPDFPage.cpp

+++ b/src/pdf/SkPDFPage.cpp

@@ -32,7 +32,7 @@ void SkPDFPage::finalizePage(SkPDFCatalog* catalog, bool firstPage,

insert("Annots", annots);

}

- SkAutoTUnref<SkData> content(fDevice->copyContentToData());

+ SkAutoTDelete<SkStreamAsset> content(fDevice->content());

fContentStream.reset(new SkPDFStream(content.get()));

insert("Contents", new SkPDFObjRef(fContentStream.get()))->unref();

}

« no previous file with comments | « src/pdf/SkPDFFormXObject.cpp ('k') | src/pdf/SkPDFShader.cpp » ('j') | no next file with comments »