Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 958203002: Don't crash when we 404. (Closed)

Created:
5 years, 10 months ago by eseidel
Modified:
5 years, 10 months ago
Reviewers:
abarth-chromium
CC:
abarth-chromium, esprehn, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Don't crash when we 404. This makes debugging that case much easier. R=abarth@chromium.org BUG= Committed: https://chromium.googlesource.com/external/mojo/+/06cf6efe09b7e73d4a917814c78636bd6fd91a34

Patch Set 1 #

Patch Set 2 : Works! #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -5 lines) Patch
M sky/apk/demo/org/domokit/sky/demo/SkyDemoActivity.java View 1 1 chunk +6 lines, -0 lines 0 comments Download
M sky/engine/web/WebLocalFrameImpl.cpp View 1 4 chunks +24 lines, -5 lines 0 comments Download
M sky/services/oknet/src/org/domokit/oknet/UrlLoaderImpl.java View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
eseidel
5 years, 10 months ago (2015-02-26 20:55:38 UTC) #1
abarth-chromium
lgtm
5 years, 10 months ago (2015-02-26 22:50:09 UTC) #2
eseidel
5 years, 10 months ago (2015-02-26 23:03:44 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
06cf6efe09b7e73d4a917814c78636bd6fd91a34 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698