Don't crash when we 404.

sky/engine/web/WebLocalFrameImpl.cpp

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 55 matching lines @@
 // detached. Most embedders will invoke close() on the WebFrame at this point,
 // triggering its deletion unless something else is still retaining a reference.
 //
 // Thie client is expected to be set whenever the WebLocalFrameImpl is attached to
 // the DOM.
 
 #include "sky/engine/config.h"
 #include "sky/engine/web/WebLocalFrameImpl.h"
 
 #include <algorithm>
+#include "base/strings/stringprintf.h"
+#include "mojo/common/data_pipe_utils.h"
 #include "mojo/public/cpp/system/data_pipe.h"
 #include "sky/engine/bindings/exception_state.h"
 #include "sky/engine/bindings/exception_state_placeholder.h"
 #include "sky/engine/core/dom/Document.h"
 #include "sky/engine/core/dom/Node.h"
 #include "sky/engine/core/dom/NodeTraversal.h"
 #include "sky/engine/core/dom/shadow/ShadowRoot.h"
 #include "sky/engine/core/editing/Editor.h"
 #include "sky/engine/core/editing/FrameSelection.h"
+#include "sky/engine/core/editing/htmlediting.h"
 #include "sky/engine/core/editing/InputMethodController.h"
 #include "sky/engine/core/editing/PlainTextRange.h"
 #include "sky/engine/core/editing/SpellChecker.h"
 #include "sky/engine/core/editing/TextAffinity.h"
 #include "sky/engine/core/editing/TextIterator.h"
-#include "sky/engine/core/editing/htmlediting.h"
 #include "sky/engine/core/frame/FrameHost.h"
 #include "sky/engine/core/frame/FrameView.h"
 #include "sky/engine/core/frame/LocalDOMWindow.h"
 #include "sky/engine/core/frame/Settings.h"
 #include "sky/engine/core/html/HTMLAnchorElement.h"
 #include "sky/engine/core/inspector/ConsoleMessage.h"
 #include "sky/engine/core/loader/MojoLoader.h"
 #include "sky/engine/core/page/EventHandler.h"
 #include "sky/engine/core/page/FocusController.h"
 #include "sky/engine/core/page/Page.h"
 #include "sky/engine/core/rendering/HitTestResult.h"
 #include "sky/engine/core/rendering/RenderBox.h"
 #include "sky/engine/core/rendering/RenderLayer.h"
 #include "sky/engine/core/rendering/RenderObject.h"
 #include "sky/engine/core/rendering/RenderTreeAsText.h"
 #include "sky/engine/core/rendering/RenderView.h"
 #include "sky/engine/core/rendering/style/StyleInheritedData.h"
-#include "sky/engine/platform/TraceEvent.h"
 #include "sky/engine/platform/clipboard/ClipboardUtilities.h"
 #include "sky/engine/platform/fonts/FontCache.h"
 #include "sky/engine/platform/graphics/GraphicsContext.h"
 #include "sky/engine/platform/graphics/skia/SkiaUtils.h"
 #include "sky/engine/platform/heap/Handle.h"
 #include "sky/engine/platform/network/ResourceRequest.h"
+#include "sky/engine/platform/TraceEvent.h"
 #include "sky/engine/platform/weborigin/KURL.h"
 #include "sky/engine/platform/weborigin/SecurityPolicy.h"
 #include "sky/engine/public/platform/Platform.h"
 #include "sky/engine/public/platform/WebFloatPoint.h"
 #include "sky/engine/public/platform/WebFloatRect.h"
 #include "sky/engine/public/platform/WebLayer.h"
 #include "sky/engine/public/platform/WebPoint.h"
 #include "sky/engine/public/platform/WebRect.h"
 #include "sky/engine/public/platform/WebSize.h"
 #include "sky/engine/public/platform/WebURLError.h"
@@ skipping 140 matching lines @@
 
 void WebLocalFrameImpl::load(const WebURL& url)
 {
     frame()->mojoLoader().init(url);
     m_fetcher = adoptPtr(new MojoFetcher(this, url));
 }
 
 void WebLocalFrameImpl::OnReceivedResponse(mojo::URLResponsePtr response)
 {
     m_fetcher.clear();
-    if (!response->body.is_valid())
-        LOG(FATAL) << "Response has no body.";
-    frame()->mojoLoader().parse(response->body.Pass());
+    if (response->body.is_valid()) {
+        frame()->mojoLoader().parse(response->body.Pass());
+        return;
+    }
+    LOG(ERROR) << "Response for " << response->url
+        << " (status " << response->status_code  << ") has no body.";
+
+    // TODO(eseidel): This is a hack, but makes debugging way easier.
+    mojo::DataPipe pipe;
+    frame()->mojoLoader().parse(pipe.consumer_handle.Pass());
+    std::string error_response = base::StringPrintf(
+        "<error><h>Empty Body</h><l>%d %s</l><m>%s</m></t></error>",
+        response->status_code, response->status_line.get().c_str(),
+        response->error->description.get().c_str());
+
+    uint32_t length = error_response.length();
+    MojoWriteData(pipe.producer_handle.get().value(),
+                  error_response.data(),
+                  &length,
+                  MOJO_WRITE_DATA_FLAG_ALL_OR_NONE);
 }
 
 void WebLocalFrameImpl::replaceSelection(const WebString& text)
 {
     bool selectReplacement = false;
     bool smartReplace = true;
     frame()->editor().replaceSelectionWithText(text, selectReplacement, smartReplace);
 }
 
 void WebLocalFrameImpl::insertText(const WebString& text)
@@ skipping 301 matching lines @@
 
 void WebLocalFrameImpl::setInputEventsTransformForEmulation(const IntSize& offset, float contentScaleFactor)
 {
     m_inputEventsOffsetForEmulation = offset;
     m_inputEventsScaleFactorForEmulation = contentScaleFactor;
     if (frame()->view())
         frame()->view()->setInputEventsTransformForEmulation(m_inputEventsOffsetForEmulation, m_inputEventsScaleFactorForEmulation);
 }
 
 } // namespace blink