content/browser/frame_host/navigation_request.h - Issue 958083002: PlzNavigate: Show error pages when the navigation failed before commit

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/navigation_request.h

Issue 958083002: PlzNavigate: Show error pages when the navigation failed before commit (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@support-data-urls

Patch Set: Updated test Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/frame_host/navigation_request.h

diff --git a/content/browser/frame_host/navigation_request.h b/content/browser/frame_host/navigation_request.h

index cfb94bf9143390f4a45730e48ed388c2ded1ff3d..ce5c5468b10897cef36843977db4064f5bbe8f89 100644

--- a/content/browser/frame_host/navigation_request.h

+++ b/content/browser/frame_host/navigation_request.h

@@ -134,7 +134,7 @@ class CONTENT_EXPORT NavigationRequest : public NavigationURLLoaderDelegate {

const scoped_refptr<ResourceResponse>& response) override;

void OnResponseStarted(const scoped_refptr<ResourceResponse>& response,

scoped_ptr<StreamHandle> body) override;

- void OnRequestFailed(int net_error) override;

+ void OnRequestFailed(bool has_stale_copy_in_cache, int net_error) override;

void OnRequestStarted(base::TimeTicks timestamp) override;

FrameTreeNode* frame_tree_node_;

« no previous file with comments | « content/browser/browser_side_navigation_browsertest.cc ('k') | content/browser/frame_host/navigation_request.cc » ('j') | no next file with comments »