Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Unified Diff: content/browser/frame_host/navigation_request.cc

Issue 958083002: PlzNavigate: Show error pages when the navigation failed before commit (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@support-data-urls
Patch Set: Updated test Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/frame_host/navigation_request.h ('k') | content/browser/frame_host/navigator.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/frame_host/navigation_request.cc
diff --git a/content/browser/frame_host/navigation_request.cc b/content/browser/frame_host/navigation_request.cc
index e5973ee3284556933bebee93e008f511026f5236..f46eecba30ff0f5b1d9a3d4f827d50c90949d76d 100644
--- a/content/browser/frame_host/navigation_request.cc
+++ b/content/browser/frame_host/navigation_request.cc
@@ -203,11 +203,12 @@ void NavigationRequest::OnResponseStarted(
response.get(), body.Pass());
}
-void NavigationRequest::OnRequestFailed(int net_error) {
+void NavigationRequest::OnRequestFailed(bool has_stale_copy_in_cache,
+ int net_error) {
DCHECK(state_ == STARTED);
state_ = FAILED;
- // TODO(davidben): Network failures should display a network error page.
- NOTIMPLEMENTED() << " where net_error=" << net_error;
+ frame_tree_node_->navigator()->FailedNavigation(
+ frame_tree_node_, has_stale_copy_in_cache, net_error);
}
void NavigationRequest::OnRequestStarted(base::TimeTicks timestamp) {
« no previous file with comments | « content/browser/frame_host/navigation_request.h ('k') | content/browser/frame_host/navigator.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698