content/child/blink_platform_impl.cc - Issue 958083002: PlzNavigate: Show error pages when the navigation failed before commit

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/child/blink_platform_impl.cc

Issue 958083002: PlzNavigate: Show error pages when the navigation failed before commit (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@support-data-urls

Patch Set: Added a browsertest Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/loader/navigation_url_loader_delegate.h ('K') | « content/browser/loader/resource_dispatcher_host_impl.cc ('k') | content/child/web_url_loader_impl.h » ('j') | content/public/test/test_navigation_observer.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/child/blink_platform_impl.cc

diff --git a/content/child/blink_platform_impl.cc b/content/child/blink_platform_impl.cc

index 2c71a251fcc9e844bf7babe5fd2bbfdc86288099..9dad44696a393d7fdf8a26ef2afc679b3dc31cb2 100644

--- a/content/child/blink_platform_impl.cc

+++ b/content/child/blink_platform_impl.cc

@@ -43,6 +43,7 @@

#include "content/child/thread_safe_sender.h"

#include "content/child/web_discardable_memory_impl.h"

#include "content/child/web_url_loader_impl.h"

+#include "content/child/web_url_request_util.h"

#include "content/child/websocket_bridge.h"

#include "content/child/webthread_impl.h"

#include "content/child/worker_task_runner.h"

@@ -494,7 +495,7 @@ WebData BlinkPlatformImpl::parseDataURL(const WebURL& url,

WebURLError BlinkPlatformImpl::cancelledError(

const WebURL& unreachableURL) const {

- return WebURLLoaderImpl::CreateError(unreachableURL, false, net::ERR_ABORTED);

+ return CreateWebURLError(unreachableURL, false, net::ERR_ABORTED);

}

bool BlinkPlatformImpl::isReservedIPAddress(