content/browser/loader/navigation_url_loader_delegate.h - Issue 958083002: PlzNavigate: Show error pages when the navigation failed before commit

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/loader/navigation_url_loader_delegate.h

Issue 958083002: PlzNavigate: Show error pages when the navigation failed before commit (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@support-data-urls

Patch Set: Added a browsertest Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/browser_side_navigation_browsertest.cc ('K') | « content/browser/loader/navigation_resource_handler.cc ('k') | content/browser/loader/navigation_url_loader_impl.h » ('j') | content/public/test/test_navigation_observer.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/loader/navigation_url_loader_delegate.h

diff --git a/content/browser/loader/navigation_url_loader_delegate.h b/content/browser/loader/navigation_url_loader_delegate.h

index f558c754579a2541c2261ec47c6c89ffebf70c8c..71f58673883a80f318e68876131674699b941f02 100644

--- a/content/browser/loader/navigation_url_loader_delegate.h

+++ b/content/browser/loader/navigation_url_loader_delegate.h

@@ -36,8 +36,10 @@ class CONTENT_EXPORT NavigationURLLoaderDelegate {

scoped_ptr<StreamHandle> body_stream) = 0;

// Called if the request fails before receving a response. |net_error| is a

- // network error code for the failure.

- virtual void OnRequestFailed(int net_error) = 0;

+ // network error code for the failure. |has_stale_copy_in_cache| is true if

+ // there is a stale

+ // copy of the unreachable page in cache.

Charlie Reis 2015/04/10 22:54:44 nit: Unexpected newline after stale

clamy 2015/04/14 11:56:25 Done.

+ virtual void OnRequestFailed(bool has_stale_copy_in_cache, int net_error) = 0;

// Called after the network request has begun on the IO thread at time

// |timestamp|. This is just a thread hop but is used to compare timing