content/browser/frame_host/render_frame_host_impl.h - Issue 958083002: PlzNavigate: Show error pages when the navigation failed before commit

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/render_frame_host_impl.h

Issue 958083002: PlzNavigate: Show error pages when the navigation failed before commit (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@support-data-urls

Patch Set: Added a browsertest Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/browser_side_navigation_browsertest.cc ('K') | « content/browser/frame_host/navigator_impl.cc ('k') | content/browser/frame_host/render_frame_host_impl.cc » ('j') | content/browser/loader/navigation_url_loader_delegate.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/render_frame_host_impl.h

diff --git a/content/browser/frame_host/render_frame_host_impl.h b/content/browser/frame_host/render_frame_host_impl.h

index 283be24ef7bcbd431ae8bec34dc477a1823255b4..a09e67d81ede457f244e1d5e0f1628ef0f8d4097 100644

--- a/content/browser/frame_host/render_frame_host_impl.h

+++ b/content/browser/frame_host/render_frame_host_impl.h

@@ -415,6 +415,14 @@ class CONTENT_EXPORT RenderFrameHostImpl

const CommonNavigationParams& common_params,

const RequestNavigationParams& request_params);

+ // PlzNavigate

+ // Indicates that a navigation failed and that this RenderFrame should display

+ // an error page.

+ void FailedNavigation(const CommonNavigationParams& common_params,

+ const RequestNavigationParams& request_params,

+ bool has_stale_copy_in_cache,

+ int error_code);

// Sets up the Mojo connection between this instance and its associated render

// frame if it has not yet been set up.

void SetUpMojoIfNeeded();