Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(551)

Unified Diff: content/browser/frame_host/render_frame_host_impl.cc

Issue 958083002: PlzNavigate: Show error pages when the navigation failed before commit (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@support-data-urls
Patch Set: Added a browsertest Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/render_frame_host_impl.cc
diff --git a/content/browser/frame_host/render_frame_host_impl.cc b/content/browser/frame_host/render_frame_host_impl.cc
index d4cc6f50c5f352ef7c908d8f5601785b97335ec6..20af4cdff6f259916bb7bb5182a9fa05ac13e30a 100644
--- a/content/browser/frame_host/render_frame_host_impl.cc
+++ b/content/browser/frame_host/render_frame_host_impl.cc
@@ -1716,6 +1716,19 @@ void RenderFrameHostImpl::CommitNavigation(
stream_handle_ = body.Pass();
}
+void RenderFrameHostImpl::FailedNavigation(
+ const CommonNavigationParams& common_params,
+ const RequestNavigationParams& request_params,
+ bool has_stale_copy_in_cache,
+ int error_code) {
+ // Get back to a clean state, in case a new navigation started without
+ // completing a RFH swap or unload handler.
+ SetState(RenderFrameHostImpl::STATE_DEFAULT);
+
+ Send(new FrameMsg_FailedNavigation(routing_id_, common_params, request_params,
+ has_stale_copy_in_cache, error_code));
+}
+
void RenderFrameHostImpl::SetUpMojoIfNeeded() {
if (service_registry_.get())
return;

Powered by Google App Engine
This is Rietveld 408576698