Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(492)

Unified Diff: content/browser/frame_host/navigator.h

Issue 958083002: PlzNavigate: Show error pages when the navigation failed before commit (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@support-data-urls
Patch Set: Fixed replace computation Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/navigator.h
diff --git a/content/browser/frame_host/navigator.h b/content/browser/frame_host/navigator.h
index 7390426a8d41a72b0c59c68d440a1ba678270dde..a61f45a00acd8cce2b1c1b0ac55a4b6b7b394934 100644
--- a/content/browser/frame_host/navigator.h
+++ b/content/browser/frame_host/navigator.h
@@ -143,6 +143,14 @@ class CONTENT_EXPORT Navigator : public base::RefCounted<Navigator> {
scoped_ptr<StreamHandle> body);
// PlzNavigate
+ // Called when a NavigationRequest for |frame_tree_node| failed. An
+ // appropriate RenderFrameHost should be selected and asked to show an error
+ // page.
Charlie Reis 2015/04/09 00:07:30 Please add what has_stale_copy_in_cache means. Is
clamy 2015/04/10 14:04:49 Done. This is needed by the WebURLError, which is
+ virtual void FailedNavigation(FrameTreeNode* frame_tree_node,
+ bool has_stale_copy_in_cache,
+ int error_code) {}
+
+ // PlzNavigate
// Cancel a NavigationRequest for |frame_tree_node|. Called when
// |frame_tree_node| is destroyed.
virtual void CancelNavigation(FrameTreeNode* frame_tree_node) {}

Powered by Google App Engine
This is Rietveld 408576698