content/browser/frame_host/navigation_request.cc - Issue 958083002: PlzNavigate: Show error pages when the navigation failed before commit

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/navigation_request.cc

Issue 958083002: PlzNavigate: Show error pages when the navigation failed before commit (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@support-data-urls

Patch Set: Fixed replace computation Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/frame_host/navigation_request.cc

diff --git a/content/browser/frame_host/navigation_request.cc b/content/browser/frame_host/navigation_request.cc

index e5973ee3284556933bebee93e008f511026f5236..c78d4b8a1821686d38a6b723d45800b442688682 100644

--- a/content/browser/frame_host/navigation_request.cc

+++ b/content/browser/frame_host/navigation_request.cc

@@ -203,11 +203,11 @@ void NavigationRequest::OnResponseStarted(

response.get(), body.Pass());

}

-void NavigationRequest::OnRequestFailed(int net_error) {

+void NavigationRequest::OnRequestFailed(bool in_cache, int net_error) {

Charlie Reis 2015/04/09 00:07:30 Please use the same name as in Navigator (has_stal

clamy 2015/04/10 14:04:49 Done.

DCHECK(state_ == STARTED);

state_ = FAILED;

- // TODO(davidben): Network failures should display a network error page.

- NOTIMPLEMENTED() << " where net_error=" << net_error;

+ frame_tree_node_->navigator()->FailedNavigation(frame_tree_node_, in_cache,

+ net_error);

}

void NavigationRequest::OnRequestStarted(base::TimeTicks timestamp) {

« no previous file with comments | « content/browser/frame_host/navigation_request.h ('k') | content/browser/frame_host/navigator.h » ('j') | content/browser/frame_host/navigator.h » ('J')