Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Unified Diff: pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart

Issue 957973006: dart2js: don't emit unneeded native info. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Addressed comments. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart
diff --git a/pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart b/pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart
index 3e913abf59d5bb9d27ed5607fc42fef7ffaaee84..24343793de88d5070844642da0bf116b91045589 100644
--- a/pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart
+++ b/pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart
@@ -173,8 +173,8 @@ class ModelEmitter {
interceptorsByTagAccess,
leafTagsAccess);
- nativeHoles['hasNativeClasses'] = program.outputContainsNativeClasses;
- nativeHoles['hasNoNativeClasses'] = !program.outputContainsNativeClasses;
+ nativeHoles['needsNativeSupport'] = program.needsNativeSupport;
+ nativeHoles['needsNoNativeSupport'] = !program.needsNativeSupport;
nativeHoles['nativeInfoHandler'] = nativeInfoHandler;
return nativeHoles;
@@ -237,7 +237,7 @@ class ModelEmitter {
globals.add(emitMetadata(program));
- if (program.outputContainsNativeClasses) {
+ if (program.needsNativeSupport) {
globals.add(new js.Property(js.string(INTERCEPTORS_BY_TAG),
js.js('Object.create(null)', [])));
globals.add(new js.Property(js.string(LEAF_TAGS),
@@ -777,7 +777,7 @@ function parseFunctionDescriptor(proto, name, descriptor) {
var name = classes[i];
var cls = classes[i + 1];
- if (#hasNativeClasses) {
+ if (#needsNativeSupport) {
// $nativeInfoDescription.
var indexOrNativeInfo = classes[i + 2];
if (typeof indexOrNativeInfo == "number") {
@@ -789,7 +789,7 @@ function parseFunctionDescriptor(proto, name, descriptor) {
}
}
- if (#hasNoNativeClasses) {
+ if (#needsNoNativeSupport) {
var holderIndex = classes[i + 2];
}
@@ -984,7 +984,7 @@ function parseFunctionDescriptor(proto, name, descriptor) {
}
}
- if (#hasNativeClasses) {
+ if (#needsNativeSupport) {
function handleNativeClassInfos() {
for (var nativeClass in nativeInfos) {
var constructor = holdersMap[nativeClass][nativeClass].ensureResolved();
@@ -1007,7 +1007,7 @@ function parseFunctionDescriptor(proto, name, descriptor) {
// generic arguments (which should be fine, but maybe there are other
// similar things).
// Initialize natives.
- if (#hasNativeClasses) handleNativeClassInfos();
+ if (#needsNativeSupport) handleNativeClassInfos();
// Initialize static non-final fields.
#staticNonFinals;
« no previous file with comments | « pkg/compiler/lib/src/js_emitter/model.dart ('k') | pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698