Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(507)

Unified Diff: pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart

Issue 957973006: dart2js: don't emit unneeded native info. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Addressed comments. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart
diff --git a/pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart b/pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart
index bbce58a28536a7dc6a33645df781061ec2993511..be681d730bdc3a583666f3f951b388ca480157ed 100644
--- a/pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart
+++ b/pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart
@@ -456,7 +456,7 @@ class OldEmitter implements Emitter {
return js(r'var inheritFrom = #', [result]);
}
- jsAst.Statement buildFinishClass(bool hasNativeClasses) {
+ jsAst.Statement buildFinishClass(bool needsNativeSupport) {
String specProperty = '"${namer.nativeSpecProperty}"'; // "%"
jsAst.Expression finishedClassesAccess =
@@ -524,13 +524,13 @@ class OldEmitter implements Emitter {
var constructor = allClasses[cls];
var prototype = inheritFrom(constructor, superConstructor);
- if (#hasNativeClasses)
+ if (#needsNativeSupport)
if (Object.prototype.hasOwnProperty.call(prototype, $specProperty))
#nativeInfoHandler
}
}''', {'finishedClassesAccess': finishedClassesAccess,
'needsMixinSupport': needsMixinSupport,
- 'hasNativeClasses': hasNativeClasses,
+ 'needsNativeSupport': needsNativeSupport,
'nativeInfoHandler': nativeInfoHandler});
}
@@ -1418,11 +1418,11 @@ class OldEmitter implements Emitter {
elementDescriptors.remove(library);
}
- bool hasNativeClasses = program.outputContainsNativeClasses;
+ bool needsNativeSupport = program.needsNativeSupport;
mainOutput
..addBuffer(
jsAst.prettyPrint(
- getReflectionDataParser(this, backend, hasNativeClasses),
+ getReflectionDataParser(this, backend, needsNativeSupport),
compiler))
..add(n);

Powered by Google App Engine
This is Rietveld 408576698