Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 957973002: remove security check from Window (Closed)

Created:
5 years, 10 months ago by dcarney
Modified:
5 years, 9 months ago
Reviewers:
haraken, marja
CC:
blink-reviews, blink-reviews-bindings_chromium.org, vivekg_samsung, arv+blink, vivekg
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

remove security check from Window it should be covered by the global object access check already R=haraken@chromium.org BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190905

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -8 lines) Patch
M Source/bindings/core/v8/WindowProxy.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/bindings/templates/interface_base.cpp View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
dcarney
ptal
5 years, 10 months ago (2015-02-26 08:38:39 UTC) #4
haraken
LGTM
5 years, 10 months ago (2015-02-26 08:40:07 UTC) #5
marja
drive by comment: is it possible to write a meaningful test here? (that stuff still ...
5 years, 10 months ago (2015-02-26 09:53:31 UTC) #7
dcarney
On 2015/02/26 09:53:31, marja wrote: > drive by comment: is it possible to write a ...
5 years, 10 months ago (2015-02-26 10:18:13 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/957973002/40001
5 years, 10 months ago (2015-02-26 10:18:48 UTC) #10
marja
(Offline discussion: this should already be covered by existing tests and I also wasn't suggesting ...
5 years, 10 months ago (2015-02-26 10:23:12 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:40001) as https://src.chromium.org/viewvc/blink?view=rev&revision=190905
5 years, 10 months ago (2015-02-26 10:53:12 UTC) #12
boliu
5 years, 9 months ago (2015-02-27 16:34:03 UTC) #13
Message was sent while issue was closed.
This caused an assertion failure in an android webview test. More details in
crbug.com/462306. Anyone here can help?

02-26 20:27:13.793  2753  2791 W WebKit  : ASSERTION FAILED:
scriptState->contextIsValid()
02-26 20:27:13.793  2753  2791 W WebKit  :
../../third_party/WebKit/Source/bindings/core/v8/ScriptState.h(35) :
blink::ScriptState::Scope::Scope(blink::ScriptState *)

Powered by Google App Engine
This is Rietveld 408576698