Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Unified Diff: Source/bindings/templates/interface_base.cpp

Issue 957973002: remove security check from Window (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/core/v8/WindowProxy.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/templates/interface_base.cpp
diff --git a/Source/bindings/templates/interface_base.cpp b/Source/bindings/templates/interface_base.cpp
index 3faaad5836828b2d9987fa4f03000d58bb46c518..cef54d9035878ba82d78f4bab90869c80f876f61 100644
--- a/Source/bindings/templates/interface_base.cpp
+++ b/Source/bindings/templates/interface_base.cpp
@@ -461,10 +461,6 @@ static void install{{v8_class}}Template(v8::Local<v8::FunctionTemplate> function
prototypeTemplate->SetInternalFieldCount(V8Window::internalFieldCount);
functionTemplate->SetHiddenPrototype(true);
instanceTemplate->SetInternalFieldCount(V8Window::internalFieldCount);
- // Set access check callbacks, but turned off initially.
- // When a context is detached from a frame, turn on the access check.
- // Turning on checks also invalidates inline caches of the object.
- instanceTemplate->SetAccessCheckCallbacks(V8Window::namedSecurityCheckCustom, V8Window::indexedSecurityCheckCustom, v8::External::New(isolate, const_cast<WrapperTypeInfo*>(&V8Window::wrapperTypeInfo)), false);
{% elif interface_name in [
'HTMLDocument', 'DedicatedWorkerGlobalScope',
'SharedWorkerGlobalScope', 'ServiceWorkerGlobalScope'] %}
« no previous file with comments | « Source/bindings/core/v8/WindowProxy.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698