net/proxy/proxy_resolver_perftest.cc - Issue 957933002: Lazily initialize the v8::Isolate used by ProxyResolverV8 (in the browser process).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/proxy/proxy_resolver_perftest.cc

Issue 957933002: Lazily initialize the v8::Isolate used by ProxyResolverV8 (in the browser process). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/proxy/proxy_resolver_perftest.cc

diff --git a/net/proxy/proxy_resolver_perftest.cc b/net/proxy/proxy_resolver_perftest.cc

index 5db69d81e48d8771aab816e74db6bd963657ab56..c4fbd73bd8e14329c634705aab1ac1c5cef5bed4 100644

--- a/net/proxy/proxy_resolver_perftest.cc

+++ b/net/proxy/proxy_resolver_perftest.cc

@@ -215,8 +215,6 @@ class MockJSBindings : public net::ProxyResolverV8::JSBindings {

};

TEST(ProxyResolverPerfTest, ProxyResolverV8) {

- net::ProxyResolverV8::EnsureIsolateCreated();

MockJSBindings js_bindings;

net::ProxyResolverV8 resolver;

resolver.set_js_bindings(&js_bindings);

« no previous file with comments | « net/proxy/mojo_proxy_resolver_factory_impl.cc ('k') | net/proxy/proxy_resolver_v8.h » ('j') | no next file with comments »