net/proxy/mojo_proxy_resolver_factory_impl.cc - Issue 957933002: Lazily initialize the v8::Isolate used by ProxyResolverV8 (in the browser process).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/proxy/mojo_proxy_resolver_factory_impl.cc

Issue 957933002: Lazily initialize the v8::Isolate used by ProxyResolverV8 (in the browser process). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/proxy/mojo_proxy_resolver_factory_impl.cc

diff --git a/net/proxy/mojo_proxy_resolver_factory_impl.cc b/net/proxy/mojo_proxy_resolver_factory_impl.cc

index 52082bc649fbab80056b9cd1ee6f2a661171f0f3..d791d4babc400b6b6dc9dc8c5f4b0067fffcbc02 100644

--- a/net/proxy/mojo_proxy_resolver_factory_impl.cc

+++ b/net/proxy/mojo_proxy_resolver_factory_impl.cc

@@ -15,7 +15,6 @@ namespace {

scoped_ptr<ProxyResolver> CreateDefaultProxyResolver(

HostResolver* host_resolver) {

- ProxyResolverV8::EnsureIsolateCreated();

return make_scoped_ptr(

new ProxyResolverV8Tracing(host_resolver, nullptr, nullptr));

}

« no previous file with comments | « chrome/browser/net/proxy_service_factory.cc ('k') | net/proxy/proxy_resolver_perftest.cc » ('j') | no next file with comments »