Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 957933002: Lazily initialize the v8::Isolate used by ProxyResolverV8 (in the browser process). (Closed)

Created:
5 years, 10 months ago by eroman
Modified:
5 years, 10 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, cbentzel+watch_chromium.org, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Lazily initialize the v8::Isolate used by ProxyResolverV8 (in the browser process). Also removes the limitation of ProxyResolverV8 not being available in single-process mode which no longer applies. BUG=454983 Committed: https://crrev.com/929aa683d7deed9cf519dce2fa0da2c7bfda5c12 Cr-Commit-Position: refs/heads/master@{#318277}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -90 lines) Patch
M chrome/browser/net/proxy_service_factory.cc View 2 chunks +0 lines, -8 lines 0 comments Download
M net/proxy/mojo_proxy_resolver_factory_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/proxy/proxy_resolver_perftest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M net/proxy/proxy_resolver_v8.h View 2 chunks +0 lines, -35 lines 0 comments Download
M net/proxy/proxy_resolver_v8.cc View 1 4 chunks +66 lines, -28 lines 0 comments Download
M net/test/run_all_unittests.cc View 2 chunks +0 lines, -16 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
eroman
5 years, 10 months ago (2015-02-26 06:55:10 UTC) #2
jochen (gone - plz use gerrit)
lgtm
5 years, 10 months ago (2015-02-26 15:06:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/957933002/20001
5 years, 10 months ago (2015-02-26 18:36:42 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-26 19:21:27 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-26 19:22:23 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/929aa683d7deed9cf519dce2fa0da2c7bfda5c12
Cr-Commit-Position: refs/heads/master@{#318277}

Powered by Google App Engine
This is Rietveld 408576698