Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 957883002: add @CustomElement (Closed)

Created:
5 years, 9 months ago by jakemac
Modified:
5 years, 9 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/web-components.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : update pubspec/changelog and add some comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -22 lines) Patch
M CHANGELOG.md View 1 1 chunk +9 lines, -0 lines 0 comments Download
A lib/src/custom_element.dart View 1 1 chunk +22 lines, -0 lines 0 comments Download
A lib/web_components.dart View 1 chunk +8 lines, -0 lines 0 comments Download
M pubspec.yaml View 1 2 chunks +2 lines, -1 line 0 comments Download
A + test/custom_element_test.dart View 3 chunks +34 lines, -18 lines 0 comments Download
A + test/custom_element_test.html View 2 chunks +8 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
jakemac
I could potentially also drop the need for `extendsTag` by keeping a table of types ...
5 years, 9 months ago (2015-02-25 23:19:32 UTC) #1
jakemac
5 years, 9 months ago (2015-02-25 23:19:40 UTC) #3
Siggi Cherem (dart-lang)
lgtm
5 years, 9 months ago (2015-02-25 23:43:43 UTC) #4
jakemac
5 years, 9 months ago (2015-02-26 15:06:30 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
4245916c520b3d276e5d42f76f5eb67aa26d6b98 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698