Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 957673005: Fix dump_dependency_json generator for iOS (Closed)

Created:
5 years, 10 months ago by sdefresne
Modified:
5 years, 10 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix dump_dependency_json generator for iOS The script tools/gyp-explain.py uses the output of the gyp generator "dump_dependency_json" so flip the condition in the gyp files to test if the generator is "xcode" instead of "ninja" (so that the generator dumping the JSON dependencies see the same dependency as the "ninja" generator). BUG=None Committed: https://crrev.com/51bfded6d6c7ef1ec7e0b7ee939ae83f7358b2a9 Cr-Commit-Position: refs/heads/master@{#318056}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M breakpad/breakpad.gyp View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
sdefresne
Please take a look. Without this patch, running build/gyp_chromium with GYP_GENERATORS=dump_dependency_json and GYP_DEFINES=OS=ios fails downstream.
5 years, 10 months ago (2015-02-25 14:45:50 UTC) #2
sdefresne
+justincohen for first review
5 years, 10 months ago (2015-02-25 14:57:07 UTC) #4
justincohen
lgtm
5 years, 10 months ago (2015-02-25 14:57:55 UTC) #5
Mark Mentovai
LGTM
5 years, 10 months ago (2015-02-25 15:27:29 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/957673005/1
5 years, 10 months ago (2015-02-25 15:31:07 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-25 16:19:17 UTC) #9
commit-bot: I haz the power
5 years, 10 months ago (2015-02-25 16:20:01 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/51bfded6d6c7ef1ec7e0b7ee939ae83f7358b2a9
Cr-Commit-Position: refs/heads/master@{#318056}

Powered by Google App Engine
This is Rietveld 408576698