Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(830)

Unified Diff: breakpad/breakpad.gyp

Issue 957673005: Fix dump_dependency_json generator for iOS (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: breakpad/breakpad.gyp
diff --git a/breakpad/breakpad.gyp b/breakpad/breakpad.gyp
index 1046c74ad28ce191e61e8026707f66a9aaedd5c4..2e2e7099a79ad92a226592bc54633ea5763ecfca 100644
--- a/breakpad/breakpad.gyp
+++ b/breakpad/breakpad.gyp
@@ -10,7 +10,7 @@
'conditions': [
# minidump_stackwalk and minidump_dump are tool-type executables that do
# not build on iOS with Xcode (but do build on iOS with ninja.)
- ['(OS!="ios" or "<(GENERATOR)"=="ninja") and OS!="win"', {
+ ['(OS!="ios" or "<(GENERATOR)"!="xcode") and OS!="win"', {
'targets': [
{
# code shared by both {micro,mini}dump_stackwalk
@@ -164,7 +164,7 @@
},
],
}],
- ['OS=="mac" or (OS=="ios" and "<(GENERATOR)"=="ninja")', {
+ ['OS=="mac" or (OS=="ios" and "<(GENERATOR)"!="xcode")', {
'target_defaults': {
'include_dirs': [
'src',
@@ -851,7 +851,7 @@
}
]
}],
- ['OS=="ios" and "<(GENERATOR)"!="ninja"', {
+ ['OS=="ios" and "<(GENERATOR)"=="xcode"', {
'variables': {
'ninja_output_dir': 'ninja-breakpad',
'ninja_product_dir':
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698