Add analyze steps to iOS try bot builds which use ninja

scripts/slave/recipe_modules/ios/api.py

Index: scripts/slave/recipe_modules/ios/api.py
diff --git a/scripts/slave/recipe_modules/ios/api.py b/scripts/slave/recipe_modules/ios/api.py
index 6a4825e77f65182471ccd5c0b1eb5d036fcf4b56..deeb5c5b6d0c629170f60e2fe9de0857ac28c1e9 100644
--- a/scripts/slave/recipe_modules/ios/api.py
+++ b/scripts/slave/recipe_modules/ios/api.py
@@ -2,6 +2,8 @@
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
+import copy
+
 from slave import recipe_api
 
 
@@ -122,7 +124,11 @@ class iOSApi(recipe_api.RecipeApi):
       '--version', self.__config['xcode version'],
     ], step_test_data=lambda: self.m.json.test_api.output({}))
 
-  def build(self, official=False):
+    self.m.chromium.make_config().gyp_env.GYP_DEFINES = copy.deepcopy(

[Paweł Hajdan Jr., 2015/02/27 08:08:13]

Could you replace "make_config()" with "c"? We use the latter and I haven't seen
the former much.

Please let me know if this doesn't work, and then consider asking Robbie or
Aaron for the best solution. I'll be fine with any recommendation they make.

My specific concern here is whether make_config() creates a _temporary_ config
object, and so whether other modules are going to see this change. If the
current code works, "c" should also work and would be more consistent with other
code.

[smut, 2015/02/27 19:09:06]

Okay, I figured out the actual correct way to do this.

+      self.__config['GYP_DEFINES']
+    )
+
+  def build(self):
     """Builds from this bot's build config."""
     assert self.__config is not None
 
@@ -171,6 +177,10 @@ class iOSApi(recipe_api.RecipeApi):
       '<br />GYP_DEFINES:<br />%s' % '<br />'.join(gyp_defines)
     )
 
+    if self.compiler == 'ninja' and self.m.tryserver.is_tryserver:
+      tests = [test['app'] for test in self.__config['tests']]
+      self.m.chromium_tests.analyze(tests, tests, 'trybot_analyze_config.json')
+
     self.m.step('compile', cmd, cwd=cwd)
 
   def test(self, *args):